8000 gh-101278: Drop -gdwarf-4 flag from the BOLT build by corona10 · Pull Request #101280 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-101278: Drop -gdwarf-4 flag from the BOLT build #101280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 24, 2023
Merged

gh-101278: Drop -gdwarf-4 flag from the BOLT build #101280

merged 1 commit into from
Jan 24, 2023

Conversation

corona10
Copy link
Member
@corona10 corona10 commented Jan 24, 2023 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot mentioned this pull request Jan 24, 2023
Closed
@corona10
Copy link
Member Author
corona10 commented Jan 24, 2023 •
edited
Loading

@erlend-aasland @aaupov cc @indygreg
I verified the build success of BOLT with DWARF-5


$ llvm-dwarfdump -r 1 ./python | head | grep Compile
0x00000000: Compile Unit: length = 0x00000102, format = DWARF32, version = 0x0005, unit_type = DW_UT_compile, abbr_offset = 0x0000, addr_size = 0x08 (next unit at 0x00000106)

@corona10 corona10 merged commit a958e7d into python:main Jan 24, 2023
@corona10 corona10 deleted the gh-101278 branch January 24, 2023 10:22
@aaupov
Copy link
aaupov commented Jan 24, 2023 •
edited
Loading

BTW, -gdwarf-4 forces the emission of debug information in DWARF4 format. Clang has added an extra flag -fdebug-default-version to specify which version is the default without forcing the output of debug information (https://reviews.llvm.org/D69822).

What's the intended effect here: emit the debug information in default format (-g) or don't emit it at all (removed flag)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@corona10 @aaupov @bedevere-bot
0