10000 gh-100795: Don't call freeaddrinfo on failure. by gpshead · Pull Request #101252 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-100795: Don't call freeaddrinfo on failure. #101252

10000
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 23, 2023
Merged

gh-100795: Don't call freeaddrinfo on failure. #101252

merged 1 commit into from
Jan 23, 2023

Conversation

gpshead
Copy link
Member
@gpshead gpshead commented Jan 23, 2023 •
edited by arhadthedev
Loading

When getaddrinfo returns an error, the output pointer is in an unknown state Don't call freeaddrinfo on it. See the issue for discussion and details with links to reasoning. Most libc getaddrinfo implementations never modify the output pointer unless they are returning success.

Co-authored-by: Sergey G. Brester github@sebres.de
Co-authored-by: Oleg Iarygin oleg@arhadthedev.net

This re-does the earlier merged and reverted PR with some additional comments.

@gpshead @sebres @arhadthedev
pythongh-100795: Don't call freeaddrinfo on failure.
342a9a7 
When getaddrinfo returns an error, the output pointer is in an unknown state
Don't call freeaddrinfo on it.  See the issue for discussion and details with
links to reasoning.  _Most_ libc getaddrinfo implementations never modify the
output pointer unless they are returning success.

Co-authored-by: Sergey G. Brester <github@sebres.de>
Co-authored-by: Oleg Iarygin <dralife@yandex.ru>
@gpshead gpshead added type-bug An unexpected behavior, bug, or error needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Jan 23, 2023
@gpshead gpshead self-assigned this Jan 23, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jan 23, 2023
Closed
@gpshead gpshead merged commit b724ac2 into python:main Jan 23, 2023
@gpshead gpshead deleted the bug/gh100795/getaddrinfo-res-free branch January 23, 2023 23:03
@miss-islington
Copy link
Contributor

Thanks @gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @gpshead, I had trouble checking out the 3.11 backport branch.
Please retry by removing and re-adding the "needs backport to 3.11" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker b724ac2fe7fbb5a7a33d639cad8e748f17b325e0 3.11

@gpshead gpshead added needs backport to 3.11 only security fixes and removed needs backport to 3.11 only security fixes labels Jan 23, 2023
@miss-islington
Copy link
Contributor

Thanks @gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-101271 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jan 23, 2023
@bedevere-bot
Copy link

GH-101272 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jan 23, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 23, 2023
@gpshead @sebres
@arhadthedev @miss-islington
pythongh-100795: Don't call freeaddrinfo on failure. (pythonGH-101252)
a28aa6e 
When getaddrinfo returns an error, the output pointer is in an unknown state
Don't call freeaddrinfo on it.  See the issue for discussion and details with
links to reasoning.  _Most_ libc getaddrinfo implementations never modify the
output pointer unless they are returning success.

(cherry picked from commit b724ac2)

Co-authored-by: Gregory P. Smith <greg@krypto.org>
Co-authored-by: Sergey G. Brester <github@sebres.de>
Co-authored-by: Oleg Iarygin <dralife@yandex.ru>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 23, 2023
@gpshead @sebres
@arhadthedev @miss-islington
pythongh-100795: Don't call freeaddrinfo on failure. (pythonGH-101252)
8c873c4 
When getaddrinfo returns an error, the output pointer is in an unknown state
Don't call freeaddrinfo on it.  See the issue for discussion and details with
links to reasoning.  _Most_ libc getaddrinfo implementations never modify the
output pointer unless they are returning success.

(cherry picked from commit b724ac2)

Co-authored-by: Gregory P. Smith <greg@krypto.org>
Co-authored-by: Sergey G. Brester <github@sebres.de>
Co-authored-by: Oleg Iarygin <dralife@yandex.ru>
miss-islington added a commit that referenced this pull request Jan 23, 2023
@miss-islington @gpshead
@sebres @arhadthedev
gh-100795: Don't call freeaddrinfo on failure. (GH-101252)
8126628 
When getaddrinfo returns an error, the output pointer is in an unknown state
Don't call freeaddrinfo on it.  See the issue for discussion and details with
links to reasoning.  _Most_ libc getaddrinfo implementations never modify the
output pointer unless they are returning success.

(cherry picked from commit b724ac2)

Co-authored-by: Gregory P. Smith <greg@krypto.org>
Co-authored-by: Sergey G. Brester <github@sebres.de>
Co-authored-by: Oleg Iarygin <dralife@yandex.ru>
miss-islington added a commit that referenced this pull request Jan 23, 2023
@miss-islington @gpshead
@sebres @arhadthedev
gh-100795: Don't call freeaddrinfo on failure. (GH-101252)
5964b12 
When getaddrinfo returns an error, the output pointer is in an unknown state
Don't call freeaddrinfo on it.  See the issue for discussion and details with
links to reasoning.  _Most_ libc getaddrinfo implementations never modify the
output pointer unless they are returning success.

(cherry picked from commit b724ac2)

Co-authored-by: Gregory P. Smith <greg@krypto.org>
Co-authored-by: Sergey G. Brester <github@sebres.de>
Co-authored-by: Oleg Iarygin <dralife@yandex.ru>
@ptoscano ptoscano mentioned this pull request Feb 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

Assignees

@gpshead gpshead

Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gpshead @miss-islington @bedevere-bot @kumaraditya303
0