8000 Docs: improve sqlite3 placeholders example by erlend-aasland · Pull Request #101092 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

Docs: improve sqlite3 placeholders example #101092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 18, 2023
Merged

Docs: improve sqlite3 placeholders example #101092

merged 2 commits into from
Jan 18, 2023

Conversation

erlend-aasland
Copy link
Contributor

Use named style for executemany() example.

@bedevere-bot bedevere-bot added awaiting core review docs Documentation in the Doc dir skip news labels Jan 16, 2023
@erlend-aasland erlend-aasland added skip issue needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes skip news docs Documentation in the Doc dir and removed docs Documentation in the Doc dir skip news labels Jan 16, 2023
@erlend-aasland
Docs: improve sqlite3 placeholders example
1a93802 
Use named style for executemany() example.
@erlend-aasland erlend-aasland force-pushed the sqlite-docs/improve-placeholders-example branch from 1965c9a to 1a93802 Compare January 16, 2023 23:35
@erlend-aasland
Copy link
Contributor Author

@CAM-Gerlach / @ezio-melotti: what do you think about this change?

IMO, this is an improvement for the better, because...:

  • limiting the example code to one "snippet" per placeholder style harmonises better with the prose
  • the qmark style is a better tool for the job with the SELECT query
  • the named style is a better tool for inserting organised data

CAM-Gerlach
CAM-Gerlach approved these changes Jan 17, 2023
View reviewed changes
Copy link
Member
@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This makes a lot of sense to me, IMO.

@erlend-aasland
Copy link
Contributor Author

Thanks for the reviews!

@erlend-aasland erlend-aasland merged commit b84be8d into python:main Jan 18, 2023
@miss-islington
Copy link
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@erlend-aasland erlend-aasland deleted the sqlite-docs/improve-placeholders-example branch January 18, 2023 09:36
@bedevere-bot
Copy link

GH-101125 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 18, 2023
@erlend-aasland @miss-islington
Docs: improve sqlite3 placeholders example (pythonGH-101092)
d8aac05 
(cherry picked from commit b84be8d)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jan 18, 2023
@bedevere-bot
Copy link

GH-101126 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jan 18, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 18, 2023
@erlend-aasland @miss-islington
Docs: improve sqlite3 placeholders example (pythonGH-101092)
1d26c64 
(cherry picked from commit b84be8d)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
miss-islington added a commit that referenced this pull request Jan 18, 2023
@miss-islington @erlend-aasland
Docs: improve sqlite3 placeholders example (GH-101092)
2c1eeb5 
(cherry picked from commit b84be8d)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
miss-islington added a commit that referenced this pull request Jan 18, 2023
@miss-islington @erlend-aasland
Docs: improve sqlite3 placeholders example (GH-101092)
db65a32 
(cherry picked from commit b84be8d)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CAM-Gerlach CAM-Gerlach CAM-Gerlach approved these changes

@ezio-melotti ezio-melotti ezio-melotti approved these changes

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@erlend-aasland @miss-islington @bedevere-bot @CAM-Gerlach @ezio-melotti
0