gh-94912: Adjusted check for non-standard coroutine function marker. #100935
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…rker. The initial implementation did not correctly identify explicitly marked class instances. Follow up to 532aa4e
|
I think this could skip news? 🤔 |
|
Confirming this resolves the issues for Django ✔️ Thanks! |
| @@ -399,8 +399,6 @@ def _has_coroutine_mark(f): | |||
| while ismethod(f): | |||
| f = f.__func__ | |||
| f = functools._unwrap_partial(f) | |||
| if not (isfunction(f) or _signature_is_functionlike(f)): | |||
There was a problem hiding this comment.
What else can we mark as coroutine-like? Functions, methods, other callables like partial, classes. Anything else?
There was a problem hiding this comment.
Hi @sobolevn. I'm not sure I follow 🤔
The cases that have occurred up to Python 3.11, using the old asyncio version, have been callable classes and sync functions. Those are (now) covered. We also added tests for static and class method and lambdas (but I've not seen anyone using those).
The other case that would simplify client code is automatic detection of the __call__ method (either async def or marked) but I think the preference is not to add that.
The initial implementation did not correctly identify explicitly marked class instances.
Follow up to 532aa4e from #99247
(Bug in Python 3.12.0a4)
Integrating Python 3.12.0a4 with the Django test suite we see that the
_has_coroutine_mark()is not allowing the key case of a class being marked as an asynchronous callable. (This is my fault: in the discussion with @gvanrossum on #99247 over whether we'd cover the marked andasync def__call__cases automatically, I forgot to add the explicit test for the marked instances.)I note the
isfunction(f) or _signature_is_functionlike(f)restriction is untested, and not, I think, necessary. (If folks appliedmarkcoroutinefunction, I think we have to assume that they know what they're up to.)asyncio.iscoroutinefunctiona deprecated alias ofinspect.iscoroutinefunctionand removeasyncio.coroutines._is_coroutine#94912