8000 GH-100923: Embed jump mask in `COMPARE_OP` oparg by markshannon · Pull Request #100924 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

GH-100923: Embed jump mask in COMPARE_OP oparg #100924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jan 11, 2023
Merged

GH-100923: Embed jump mask in COMPARE_OP oparg #100924

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
3c90c33
Embed mask in COMPARE_OP oparg.
markshannon Jan 10, 2023
1e7de16
Remove mask cache entry for COMPARE_OP instructions.
markshannon Jan 10, 2023
e1d7d18
Fix dis test.
markshannon Jan 10, 2023
462f88f
Add news
markshannon Jan 10, 2023
3de3400
Fix magic number
markshannon Jan 11, 2023
10d4299
Name and document the comparison masks.
markshannon Jan 11, 2023
93fde30
Factor out comparison to bit equation.
markshannon Jan 11, 2023
9b2af6e
Regenerate cases
markshannon Jan 11, 2023
03d9c65
Update Python/compile.c
markshannon Jan 11, 2023
58e3f49
Update Python/compile.c
markshannon Jan 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
8000
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update Python/compile.c 
Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
  • Loading branch information
@markshannon @iritkatriel
markshannon and iritkatriel authored Jan 11, 2023
commit 03d9c6568ad2f58e10730d6e581b4e8811e619c0
3 changes: 2 additions & 1 deletion Python/compile.c
8000
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2887,7 +2887,8 @@ static int compiler_addcompare(struct compiler *c, location loc,
default:
Py_UNREACHABLE();
}
/* cmp goes in top bits of the oparg, low bits are for the mask. */
/* cmp goes in top bits of the oparg, while the low bits are used by specialized
* versions of this opcode to store the comparison mask. */
ADDOP_I(c, loc, COMPARE_OP, cmp << 4);
return SUCCESS;
}
Expand Down
0