8000 GH-98831: Modernize a ton of simpler instructions by gvanrossum · Pull Request #100545 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

GH-98831: Modernize a ton of simpler instructions #100545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 32 commits into from
Dec 28, 2022
Merged

GH-98831: Modernize a ton of simpler instructions #100545

Changes from 1 commit
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
e48824d
load_const and load_fast aren't families for now
gvanrossum Dec 25, 2022
852ad17
Modernize GET_ANEXT
gvanrossum Dec 25, 2022
ec12b8c
Modernize GET_AWAITABLE
gvanrossum Dec 25, 2022
f58b421
Modernize ASYNC_GEN_WRAP
gvanrossum Dec 25, 2022
c4c821e
Modernize YIELD_VALUE
gvanrossum Dec 25, 2022
55c009c
Modernize POP_EXCEPT (in more than one way)
gvanrossum Dec 25, 2022
d678363
Modernize PREP_RERAISE_STAR
gvanrossum Dec 26, 2022
301cc6e
Modernize LOAD_ASSERTION_ERROR
gvanrossum Dec 26, 2022
84fcd61
Modernize LOAD_BUILD_CLASS
gvanrossum Dec 26, 2022
2fcb3d7
Modernize STORE_NAME
gvanrossum Dec 26, 2022
c094ff4
Modernize LOAD_NAME
gvanrossum Dec 26, 2022
c89dfd5
Modernize LOAD_CLASSDEREF
gvanrossum Dec 26, 2022
415203c
Modernize LOAD_DEREF
gvanrossum Dec 26, 2022
cc7bf1f
Modernize STORE_DEREF
gvanrossum Dec 26, 2022
304997f
Modernize COPY_FREE_VARS (mark it as done)
gvanrossum Dec 26, 2022
b388032
Modernize LIST_TO_TUPLE
gvanrossum Dec 26, 2022
a84c0e3
Modernize LIST_EXTEND
gvanrossum Dec 26, 2022
9099c40
Modernize SET_UPDATE
gvanrossum Dec 26, 2022
fc534ed
Modernize SETUP_ANNOTATIONS
gvanrossum Dec 26, 2022
3a1e63c
Modernize DICT_UPDATE
gvanrossum Dec 26, 2022
f9fc640
Modernize DICT_MERGE
gvanrossum Dec 27, 2022
ad38a3c
Modernize MAP_ADD
gvanrossum Dec 27, 2022
b4fe323
Modernize IS_OP
gvanrossum Dec 27, 2022
9e69806
Modernize CONTAINS_OP
gvanrossum Dec 27, 2022
d1aa4d5
Don't decref unmoved names
gvanrossum Dec 27, 2022
b06aafa
Modernize CHECK_EXC_MATCH
gvanrossum Dec 27, 2022
154ae46
Modernize IMPORT_NAME
gvanrossum Dec 27, 2022
d1ea957
Modernize IMPORT_STAR
gvanrossum Dec 27, 2022
9a1626e
Modernize IMPORT_FROM
gvanrossum Dec 27, 2022
d5c79e7
Modernize JUMP_FORWARD (mark it as done)
gvanrossum Dec 27, 2022
7a40a8c
Modernize JUMP_BACKWARD (mark it as done)
gvanrossum Dec 27, 2022
841f086
Add/update dummies to quiet VS Code
gvanrossum Dec 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8000
Next Next commit
load_const and load_fast aren't families for now
  • Loading branch information
@gvanrossum
gvanrossum committed Dec 25, 2022
commit e48824da30aa301e76b4e03abe8c8407bf70ff82
2 changes: 0 additions & 2 deletions Python/bytecodes.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3631,8 +3631,6 @@ family(load_attr) = {
LOAD_ATTR_PROPERTY, LOAD_ATTR_SLOT, LOAD_ATTR_WITH_HINT,
LOAD_ATTR_METHOD_LAZY_DICT, LOAD_ATTR_METHOD_NO_DICT, LOAD_ATTR_METHOD_WITH_DICT,
LOAD_ATTR_METHOD_WITH_VALUES };
family(load_const) = { LOAD_CONST, LOAD_CONST__LOAD_FAST };
family(load_fast) = { LOAD_FAST, LOAD_FAST__LOAD_CONST, LOAD_FAST__LOAD_FAST };
Comment on lines -3634 to -3635
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these families being removed?

Copy link
Member Author
@gvanrossum gvanrossum Dec 28, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part of the file isn't parsed anyway, and if we moved these families into a part where they would be parsed the generator would complain, because it currently doesn't support super-instructions as part of a family.

See also faster-cpython/ideas#495

family(load_global) = {
LOAD_GLOBAL, LOAD_GLOBAL_BUILTIN,
LOAD_GLOBAL_MODULE };
Expand Down
0