8000 gh-99942: python.pc on android/cygwin should link to libpython per configure.ac by eli-schwartz · Pull Request #100356 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-99942: python.pc on android/cygwin should link to libpython per configure.ac #100356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 22, 2023
Merged

gh-99942: python.pc on android/cygwin should link to libpython per configure.ac #100356

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57e63ca
gh-99942: fix regression in python.pc that broke linking on android/c…
eli-schwartz Dec 20, 2022
0895ecf
Merge branch 'main' into pkgconfig-libpython
gpshead Feb 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
8000
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
gh-99942: fix regression in python.pc that broke linking on android/c… 
…ygwin

In commit 254b309 a previous change to
avoid linking to libpython was partially reverted for Android (and later
Cygwin as well), to add back the link flags. This was applied to
distutils and to python-config.sh, but not to python.pc.

Add it back to python.pc as well.
  • Loading branch information
@eli-schwartz
eli-schwartz committed Dec 20, 2022
commit 57e63cad06441bddc181d935f0fff3779a05f13a
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Build/2022-12-20-01-06-17.gh-issue-99942.lbmzYj.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
On Android, python.pc now correctly reports the library to link to, the same
as python-config.sh.
2 changes: 1 addition & 1 deletion Misc/python.pc.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,5 @@ Description: Build a C extension for Python
Requires:
Version: @VERSION@
Libs.private: @LIBS@
Libs:
Libs: -L${libdir} @LIBPYTHON@
Cflags: -I${includedir}/python@VERSION@@ABIFLAGS@
0