10BC0 [Skip Issue] Replace dead code with an assertion in winreg.c by ZackerySpytz · Pull Request #10028 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

[Skip Issue] Replace dead code with an assertion in winreg.c #10028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
serhiy-storchaka merged 2 commits into from
Nov 8, 2018
Merged

[Skip Issue] Replace dead code with an assertion in winreg.c #10028

serhiy-storchaka merged 2 commits into from
Nov 8, 2018

Conversation

@ZackerySpytz
Copy link
Contributor
@ZackerySpytz ZackerySpytz commented Oct 21, 2018

No description provided.

@ZackerySpytz ZackerySpytz requested a review from a team as a code owner October 21, 2018 12:29
@serhiy-storchaka
Copy link
Member
serhiy-storchaka commented Oct 21, 2018

Actually PyUnicode_AsUnicodeAndSize() shouldn't fail here. It could fail at the first iteration.

@serhiy-storchaka serhiy-storchaka dismissed their stale review October 21, 2018 13:08

This code is never executed.

@serhiy-storchaka
Copy link
Member
serhiy-storchaka commented Oct 21, 2018

I would rather replace the check with an assert.

@ZackerySpytz
Copy link
Contributor Author
ZackerySpytz commented Oct 23, 2018

It seems fragile to rely wholly on the previous PyUnicode_AsUnicodeAndSize() calls. It would be safest to keep the NULL check.

@serhiy-storchaka
Copy link
Member
serhiy-storchaka commented Oct 23, 2018

We already rely on the previous PyUnicode_AsUnicodeAndSize() calls. If the second call can return a different pointer, it can return also a different size. And it that case we will get a buffer overwriting.

I suggest to add two asserts, for pointer and for length.

@ZackerySpytz ZackerySpytz changed the title [Skip Issue] Fix a possible memory leak in winreg.c [Skip Issue] Replace dead code with an assertion in winreg.c Nov 1, 2018
@ZackerySpytz
Copy link
Contributor Author
ZackerySpytz commented Nov 1, 2018

@serhiy-storchaka Thank you for your remarks, Serhiy. I've replaced the check with an assertion.

@serhiy-storchaka serhiy-storchaka merged commit 5d95312 into python:master Nov 8, 2018
@serhiy-storchaka serhiy-storchaka removed the type-bug An unexpected behavior, bug, or error label Nov 8, 2018
@Carole1
Copy link
Carole1 commented Nov 8, 2018

with these code problems, I'm not ready yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka left review comments

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ZackerySpytz @serhiy-storchaka @Carole1 @the-knights-who-say-ni @bedevere-bot
0