8000 gh-99941: asyncio.Protocol.data_received now received immutable bytes by DarioDaF · Pull Request #100053 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-99941: asyncio.Protocol.data_received now received immutable bytes #100053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 10, 2022
Merged

gh-99941: asyncio.Protocol.data_received now received immutable bytes #100053

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
aad3337
Moving transport data_read to bytes through memoryview
DarioDaF Dec 6, 2022
1a5af35
Added test case for #99941
DarioDaF Dec 6, 2022
d9e22f7
Added blurb
DarioDaF Dec 6, 2022
e101911
Simplify news entry
gvanrossum Dec 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Simplify news entry
  • Loading branch information
@gvanrossum
gvanrossum authored Dec 10, 2022
commit e101911355177b6aac3fb4f07159f2c5b1c3854b
8 changes: 2 additions & 6 deletions Misc/NEWS.d/next/Windows/2022-12-06-11-16-46.gh-issue-99941.GmUQ6o.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,2 @@
Made :func:`asyncio.Protocol.data_received` receive immutable object
``bytes`` instead of ``bytearrays`` with regression tests added and opted to
use ``memoryview`` to take the slices for performance on big buffers.
Performance test from ``gh-issue:21442`` done on my machine with 10
repetitions on release build with timings 0.043 (delta: 0.019) before patch
and 0.041 (delta: 0.010) after so no noticable change in performance.
Ensure that :func:`asyncio.Protocol.data_received` receives an immutable
:class:`bytes` object (as documented), instead of :class:`bytearray`.
0