8000 `descr_set_trampoline_call` return type should be `int` not `PyObject*` · Issue #99443 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

descr_set_trampoline_call return type should be int not PyObject* #99443

New issue
10000

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hoodmane opened this issue Nov 13, 2022 · 2 comments
Closed

descr_set_trampoline_call return type should be int not PyObject* #99443

hoodmane opened this issue Nov 13, 2022 · 2 comments
Labels
type-bug An unexpected behavior, bug, or error

Comments

@hoodmane
Copy link
Contributor
hoodmane commented Nov 13, 2022 •
edited by arhadthedev
Loading

getset_set return type is int, descr_set_trampoline_call's return type needs to be the same. I think this was a copy-paste error that occurred when applying my patch where descr_set_trampoline_call returns int:
https://github.com/pyodide/pyodide/blob/main/cpython/patches/0001-Patch-in-call-trampolines-to-handle-fpcast-troubles.patch

Linked PRs
@hoodmane hoodmane added the type-bug An unexpected behavior, bug, or error label Nov 13, 2022
@bedevere-bot bedevere-bot mentioned this issue Nov 13, 2022
Merged
@ezio-melotti ezio-melotti mentioned this issue Nov 13, 2022
Merged
@hoodmane
Copy link
Contributor Author
hoodmane commented Nov 14, 2022 •
edited
Loading

See also #91318. This comes up from Pyodide's upgrade to Python 3.11. I'm not sure why I didn't notice it before.

@tiran

gvanrossum pushed a commit that referenced this issue Nov 16, 2022
@hoodmane
gh-99443: descr_set_trampoline_call return type should be int not…
bc390dd 
… `PyObject*` (#99444)
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Nov 16, 2022
@hoodmane @miss-islington
pythongh-99443: descr_set_trampoline_call return type should be `in…
03fb597 
…t` not `PyObject*` (pythonGH-99444)

(cherry picked from commit bc390dd)

Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com>
@bedevere-bot bedevere-bot mentioned this issue Nov 16, 2022
Merged
miss-islington added a commit that referenced this issue Nov 16, 2022
@miss-islington @hoodmane
gh-99443: descr_set_trampoline_call return type should be int not…
bbac9a8 
… `PyObject*` (GH-99444)

(cherry picked from commit bc390dd)

Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com>
@hauntsaninja
Copy link
Contributor

Thanks for fixing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hoodmane @hauntsaninja
0