8000 CI testing for pull requests can fail if multiple workloads exist with the same name · Issue #134309 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

CI testing for pull requests can fail if multiple workloads exist with the same name #134309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
abstractedfox opened this issue May 20, 2025 · 0 comments
Closed

CI testing for pull requests can fail if multiple workloads exist with the same name #134309

abstractedfox opened this issue May 20, 2025 · 0 comments
Labels
infra CI, GitHub Actions, buildbots, Dependabot, etc. type-bug An unexpected behavior, bug, or error

Comments

@abstractedfox
Copy link
Contributor
abstractedfox commented May 20, 2025 •
edited by bedevere-app bot
Loading

Bug report

Bug description:

If more than one PR is opened from branches with the same name, CI testing fails due to mandatory tests being canceled. This is due to the way concurrency groups are named; there is a PR coming with a fix.

CPython versions tested on:

CPython main branch

Operating systems tested on:

No response

Linked PRs
@abstractedfox abstractedfox added the type-bug An unexpected behavior, bug, or error label May 20, 2025
@bedevere-app bedevere-app bot mentioned this issue May 20, 2025
Merged
@picnixz picnixz added the infra CI, GitHub Actions, buildbots, Dependabot, etc. label May 20, 2025
AA-Turner added a commit that referenced this issue May 22, 2025
@abstractedfox @AA-Turner
@webknjaz @CAM-Gerlach
gh-134309: Add github.actor to the GitHub Actions concurrency key (…
979d81a 
…#134310)

When inexperienced users create a PR from their default branch, all of the concurrency keys
collide as there is no namespacing. This becomes an issue at events with many new contributors,
where workflow runs are cancelled on other pull requests.
Disambiguate by adding the username of the relevant 'actor' to the concurrency key.

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Sviatoslav Sydorenko <sviat@redhat.com>
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
Authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue May 22, 2025
@abstractedfox @AA-Turner
@webknjaz @CAM-Gerlach @miss-islington
pythongh-134309: Add github.actor to the GitHub Actions concurren…
8a350ad 
…cy key (pythonGH-134310)

When inexperienced users create a PR from their default branch, all of the concurrency keys
collide as there is no namespacing. This becomes an issue at events with many new contributors,
where workflow runs are cancelled on other pull requests.
Disambiguate by adding the username of the relevant 'actor' to the concurrency key.
(cherry picked from commit 979d81a)

Co-authored-by: Kira <coldcaption@gmail.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Sviatoslav Sydorenko <sviat@redhat.com>
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
Authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue May 22, 2025
@abstractedfox @AA-Turner
@webknjaz @CAM-Gerlach @miss-islington
pythongh-134309: Add github.actor to the GitHub Actions concurren…
f026c0a 
…cy key (pythonGH-134310)

When inexperienced users create a PR from their default branch, all of the concurrency keys
collide as there is no namespacing. This becomes an issue at events with many new contributors,
where workflow runs are cancelled on other pull requests.
Disambiguate by adding the username of the relevant 'actor' to the concurrency key.
(cherry picked from commit 979d81a)

Co-authored-by: Kira <coldcaption@gmail.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Sviatoslav Sydorenko <sviat@redhat.com>
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
Authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
This was referenced May 22, 2025
Merged
Merged
AA-Turner added a commit that referenced this issue May 8000 22, 2025
@miss-islington @abstractedfox
@AA-Turner @webknjaz @CAM-Gerlach
[3.13] gh-134309: Add github.actor to the GitHub Actions concurre…
55aba16 
…ncy key (GH-134310) (#134485)

gh-134309: Add ``github.actor`` to the GitHub Actions concurrency key (GH-134310)

When inexperienced users create a PR from their default branch, all of the concurrency keys
collide as there is no namespacing. This becomes an issue at events with many new contributors,
where workflow runs are cancelled on other pull requests.
Disambiguate by adding the username of the relevant 'actor' to the concurrency key.
(cherry picked from commit 979d81a)





Authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>

Co-authored-by: Kira <coldcaption@gmail.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Sviatoslav Sydorenko <sviat@redhat.com>
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
AA-Turner added a commit that referenced this issue May 22, 2025
@miss-islington @abstractedfox
@AA-Turner @webknjaz @CAM-Gerlach
[3.14] gh-134309: Add github.actor to the GitHub Actions concurre…
03a2112 
…ncy key (GH-134310) (#134484)

gh-134309: Add ``github.actor`` to the GitHub Actions concurrency key (GH-134310)

When inexperienced users create a PR from their default branch, all of the concurrency keys
collide as there is no namespacing. This becomes an issue at events with many new contributors,
where workflow runs are cancelled on other pull requests.
Disambiguate by adding the username of the relevant 'actor' to the concurrency key.
(cherry picked from commit 979d81a)





Authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>

Co-authored-by: Kira <coldcaption@gmail.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Sviatoslav Sydorenko <sviat@redhat.com>
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
lkollar pushed a commit to lkollar/cpython that referenced this issue May 26, 2025
@abstractedfox @AA-Turner
@webknjaz @CAM-Gerlach @lkollar
pythongh-134309: Add github.actor to the GitHub Actions concurren…
7d2e257 
…cy key (python#134310)

When inexperienced users create a PR from their default branch, all of the concurrency keys
collide as there is no namespacing. This becomes an issue at events with many new contributors,
where workflow runs are cancelled on other pull requests.
Disambiguate by adding the username of the relevant 'actor' to the concurrency key.

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Sviatoslav Sydorenko <sviat@redhat.com>
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
Authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
infra CI, GitHub Actions, buildbots, Dependabot, etc. type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@abstractedfox @AA-Turner @picnixz
0