8000 `Tests / Check if generated files are up to date` fails since recent commits · Issue #134236 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

Tes 8000 ts / Check if generated files are up to date fails since recent commits #134236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sobolevn opened this issue May 19, 2025 · 4 comments
Closed

Tests / Check if generated files are up to date fails since recent commits #134236

sobolevn opened this issue May 19, 2025 · 4 comments
Labels
build The build process and cross-build infra CI, GitHub Actions, buildbots, Dependabot, etc. type-bug An unexpected behavior, bug, or error

Comments

@sobolevn
Copy link
Member
sobolevn commented May 19, 2025 •
edited by bedevere-app bot
Loading

Bug report

Link: https://github.com/python/cpython/actions/runs/15115778970/job/42485985691?pr=134230

Output:

diff --git a/Include/internal/pycore_opcode_metadata.h b/Include/internal/pycore_opcode_metadata.h
index 7185947..17811d3 100644
--- a/Include/internal/pycore_opcode_metadata.h
+++ b/Include/internal/pycore_opcode_metadata.h
@@ -1787,8 +1787,6 @@ const uint8_t _PyOpcode_Caches[256] = {
 extern const uint8_t _PyOpcode_Deopt[256];
 #ifdef NEED_OPCODE_METADATA
 const uint8_t _PyOpcode_Deopt[256] = {
-    [119] = 119,
-    [120] = 120,
     [121] = 121,
     [122] = 122,
     [123] = 123,
@@ -1796,7 +1794,6 @@ const uint8_t _PyOpcode_Deopt[256] = {
     [125] = 125,
     [126] = 126,
     [127] = 127,
-    [211] = 211,
     [212] = 212,
     [213] = 213,
     [214] = 214,

Refs cc9add6
CC @DinoV

I have a PR ready.

Linked PRs
@sobolevn sobolevn added type-bug An unexpected behavior, bug, or error build The build process and cross-build infra CI, GitHub Actions, buildbots, Dependabot, etc. labels May 19, 2025
sobolevn added a commit to sobolevn/cpython that referenced this issue May 19, 2025
@sobolevn
pythongh-134236: Run make regen-all and fix `Test generated files a…
646f61c 
…re up-to-date`
@bedevere-app bedevere-app bot mentioned this issue May 19, 2025
Merged
@StanFromIreland
Copy link
Member

@DinoV @sobolevn

There are duplicate prs now: #134231 and #134237

brandtbucher pushed a commit that referenced this issue May 19, 2025
@sobolevn
GH-134236: make regen-all (GH-134237)
a36ce26
@hugovk
Copy link
Member
hugovk commented May 19, 2025

#134237 has been merged.

@hugovk hugovk closed this as completed May 19, 2025
@hugovk
Copy link
Member
hugovk commented May 19, 2025

Although #134231 was merged first so #134237 was an empty commit :)

@StanFromIreland
Copy link
Member

Hmm that's not great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build The build process and cross-build infra CI, GitHub Actions, buildbots, Dependabot, etc. type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hugovk @sobolevn @StanFromIreland
0