gh-133447: Add basic color to `sqlite3` CLI by StanFromIreland · Pull Request #133461 · python/cpython

StanFromIreland · 2025-05-05T17:55:51Z

Issue: Colorize sqlite3 CLI #133447

sharktide

Seems good to me

tomasr8 · 2025-05-06T07:21:01Z

Now that #133347 has been merged, we could take advantage of it in the sqlite CLI as well?

StanFromIreland · 2025-05-06T16:04:12Z

cc @ambv Just to check -- did I use themes correctly or did I do something wrong (there is no docs at the moment to verify)?

ambv

Yeah, there are no docs so I'll push here with how I'd do it if that's okay.

Lib/sqlite3/__main__.py

ambv

Let me know what you think.

Lib/sqlite3/__main__.py

Lib/test/test_sqlite3/test_cli.py

Lib/sqlite3/__main__.py

StanFromIreland · 2025-05-06T19:12:58Z

Looks good to me now, thank you for the assistance:-)

If you need help with colorise I’d be happy to lend a hand.

ambv · 2025-05-06T19:14:34Z

Excellent! Since all this is already for 3.15, I think we might attempt a SQL syntax highlighter as well, although I'm not entirely sure our tokenizer will take kindly to it, so this might become a larger task. We have plenty of time, though.

Lib/sqlite3/__main__.py

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>

erlend-aasland · 2025-05-07T19:30:13Z

Excellent! Since all this is already for 3.15, I think we might attempt a SQL syntax highlighter as well, although I'm not entirely sure our tokenizer will take kindly to it, so this might become a larger task. We have plenty of time, though.

SQL highlighting would be awesome.

StanFromIreland · 2025-05-07T19:42:10Z

All the test fails are unrelated.

SQL highlighting would be awesome.

Working on it :-)

Lib/sqlite3/__main__.py

erlend-aasland · 2025-05-10T07:04:34Z

@StanFromIreland, please look into the failing tests.

StanFromIreland · 2025-05-10T07:28:01Z

I was testing the broken behavior that was now fixed, oops!

StanFromIreland · 2025-05-10T07:31:08Z

@erlend-aasland Test has been corrected to work with the new updates.

bedevere-bot · 2025-05-10T09:20:07Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot ARM64 Windows 3.x (tier-3) has failed when building commit 30b1d8f.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/729/builds/8781) and take a look at the build logs.
Check if the failure is related to this commit (30b1d8f) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/729/builds/8781

Failed tests:

test_zipfile

Failed subtests:

test_write_without_source_date_epoch - test.test_zipfile.test_core.OtherTests.test_write_without_source_date_epoch

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "C:\Workspace\buildarea\3.x.linaro-win-arm64\build\Lib\test\test_zipfile\test_core.py", line 1832, in test_write_without_source_date_epoch
    self.assertAlmostEqual(z_time, c_time, delta=1)
    ~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 28 != 30 within 1 delta (2 difference)


Traceback (most recent call last):
  File "C:\Workspace\buildarea\3.x.linaro-win-arm64\build\Lib\test\test_zipfile\test_core.py", line 1832, in test_write_without_source_date_epoch
    self.assertAlmostEqual(z_time, c_time, delta=1)
    ~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 36 != 38 within 1 delta (2 difference)

StanFromIreland · 2025-05-10T09:26:41Z

Unrelated.

Lib/sqlite3/__main__.py

(pythongh-133447: Add basic color to `sqlite3` CLI (python#133461))

Add

0a33388

StanFromIreland requested review from berkerpeksag and erlend-aasland as code owners May 5, 2025 17:55

bedevere-app bot mentioned this pull request May 5, 2025

Colorize sqlite3 CLI #133447

Closed

bedevere-app bot added the awaiting review label May 5, 2025

StanFromIreland and others added 2 commits May 5, 2025 18:56

Import cleanup

e680c35

Merge branch 'main' into color_step1

9bf179c

sharktide approved these changes May 5, 2025

View reviewed changes

bedevere-app bot added awaiting core review and removed awaiting review labels May 5, 2025

Highlight error messages

b456133

StanFromIreland and others added 3 commits May 6, 2025 16:54

Merge branch 'main' into color_step1

8ef9217

Now with themes!

ca015a1

Simpler usage

2c06076

Fixup

198399e

ambv reviewed May 6, 2025

View reviewed changes

Lib/sqlite3/__main__.py Outdated Show resolved Hide resolved

Lib/sqlite3/__main__.py Outdated Show resolved Hide resolved

StanFromIreland requested a review from ambv May 6, 2025 18:27

Simplify

2a8c729

ambv force-pushed the color_step1 branch from 158c50c to 2a8c729 Compare May 6, 2025 18:37

ambv reviewed May 6, 2025

View reviewed changes

Lib/sqlite3/__main__.py Show resolved Hide resolved

Lib/sqlite3/__main__.py Show resolved Hide resolved

Lib/sqlite3/__main__.py Outdated Show resolved Hide resolved

Lib/sqlite3/__main__.py Outdated Show resolved Hide resolved

Lib/test/test_sqlite3/test_cli.py Show resolved Hide resolved

Don't skip coloring errors on single-statement execution

a220442

ambv reviewed May 6, 2025

View reviewed changes

Lib/sqlite3/__main__.py Show resolved Hide resolved

ambv reviewed May 6, 2025

View reviewed changes

Lib/sqlite3/__main__.py Show resolved Hide resolved

ambv and others added 2 commits May 6, 2025 21:00

Also ignore color in the CLI test case

e65d724

Clean up

66711a0

ambv approved these changes May 6, 2025

View reviewed changes

bedevere-app bot added awaiting merge and removed awaiting core review labels May 6, 2025

erlend-aasland changed the title ~~gh-133447: Add basic color to sqlite3 cli~~ gh-133447: Add basic color to sqlite3 CLI May 7, 2025

erlend-aasland reviewed May 7, 2025

View reviewed changes

Lib/sqlite3/__main__.py Show resolved Hide resolved

Fix line removal

62a0164

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>

StanFromIreland requested a review from erlend-aasland May 7, 2025 19:27

erlend-aasland approved these changes May 7, 2025

View reviewed changes

Merge branch 'main' into color_step1

52ee84c

StanFromIreland commented May 9, 2025

View reviewed changes

Lib/sqlite3/__main__.py Show resolved Hide resolved

Lint

4ed5815

fixup! Lint

4c0b52c

erlend-aasland enabled auto-merge (squash) May 10, 2025 07:35

erlend-aasland merged commit 30b1d8f into python:main May 10, 2025
39 checks passed

bedevere-app bot removed the awaiting merge label May 10, 2025

StanFromIreland deleted the color_step1 branch May 10, 2025 07:59

hugovk reviewed May 10, 2025

View reviewed changes

Lib/sqlite3/__main__.py Show resolved Hide resolved

tanloong pushed a commit to tanloong/cpython that referenced this pull request May 10, 2025

cherry pick from and resolve conflicts with 30b1d8f on main branch

833140c

(pythongh-133447: Add basic color to `sqlite3` CLI (python#133461))

tanloong mentioned this pull request Jun 14, 2025

sqlite3 CLI does not recognize dot commands with trailing spaces #133439

Closed

Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025

pythongh-133447: Add basic color to sqlite3 CLI (python#133461)

135a100

taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025

pythongh-133447: Add basic color to sqlite3 CLI (python#133461)

746a1c0

Uh oh!

Conversation

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants