8000 Fix an example in the explanation of mock autospeccing · Issue #133413 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

Fix an example in the explanation of mock autospeccing #133413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ppaez opened this issue May 5, 2025 · 0 comments
Closed

Fix an example in the explanation of mock autospeccing #133413

ppaez opened this issue May 5, 2025 · 0 comments
Labels
3.13 bugs and security fixes 3.14 bugs and security fixes 3.15 new features, bugs and security fixes docs Documentation in the Doc dir

Comments

@ppaez
Copy link
Contributor
ppaez commented May 5, 2025 •
edited by bedevere-app bot
Loading

Documentation

The autospeccing section, in the reference for the unittest.mock module, includes an example with request.Request. The has_data method of Request is used, but it was removed in Python 3.4. A Pull Request is provided to use the header_items method instead, so the reader will see the expected result if they run the example in their PC.

Linked PRs
@ppaez ppaez added the docs Documentation in the Doc dir label May 5, 2025
@bedevere-app bedevere-app bot mentioned this issue May 5, 2025
Merged
serhiy-storchaka pushed a commit that referenced this issue May 12, 2025
@ppaez
gh-133413: Fix references to removed Request.has_data (GH-133414)
86c1d43 
The has_data() method of http.request.Request
was removed in version 3.4.
miss-islington pushed a commit to miss-islington/cpython that referenced this issue May 12, 2025
@ppaez @miss-islington
pythongh-133413: Fix references to removed Request.has_data (pythonGH…
2c9fccb 
…-133414)

The has_data() method of http.request.Request
was removed in version 3.4.
(cherry picked from commit 86c1d43)

Co-authored-by: ppaez <pp@pp.com.mx>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue May 12, 2025
@ppaez @miss-islington
pythongh-133413: Fix references to removed Request.has_data (pythonGH…
f20fdbb 
…-133414)

The has_data() method of http.request.Request
was removed in version 3.4.
(cherry picked from commit 86c1d43)

Co-authored-by: ppaez <pp@pp.com.mx>
This was referenced May 12, 2025
Merged
Merged
@serhiy-storchaka serhiy-storchaka added 3.13 bugs and security fixes 3.14 bugs and security fixes 3.15 new features, bugs and security fixes labels May 12, 2025
serhiy-storchaka pushed a commit that referenced this issue May 12, 2025
@miss-islington @ppaez
[3.14] gh-133413: Fix references to removed Request.has_data (GH-133414…
5ba525c 
…) (GH-133945)

The has_data() method of http.request.Request
was removed in version 3.4.
(cherry picked from commit 86c1d43)

Co-authored-by: ppaez <pp@pp.com.mx>
serhiy-storchaka pushed a commit that referenced this issue May 12, 2025
@miss-islington @ppaez
[3.13] gh-133413: Fix references to removed Request.has_data (GH-133414…
05ddd06 
…) (GH-133946)

The has_data() method of http.request.Request
was removed in version 3.4.
(cherry picked from commit 86c1d43)

Co-authored-by: ppaez <pp@pp.com.mx>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.13 bugs and security fixes 3.14 bugs and security fixes 3.15 new features, bugs and security fixes docs Documentation in the Doc dir
Projects
docs issues
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ppaez @serhiy-storchaka
0