8000 WASM build scripts don't honour `--with-pydebug` from build-python due to a `sysconfig` regression · Issue #131769 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

WASM build scripts don't honour --with-pydebug from build-python due to a sysconfig regression #131769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
FFY00 opened this issue Mar 26, 2025 · 3 comments
Closed

WASM build scripts don't honour --with-pydebug from build-python due to a sysconfig regression #131769

FFY00 opened this issue Mar 26, 2025 · 3 comments
Assignees
@brettcannon
Labels
3.14 bugs and security fixes 3.15 new features, bugs and security fixes build The build process and cross-build OS-wasi topic-sysconfig type-bug An unexpected behavior, bug, or error

Comments

@FFY00
Copy link
Member
FFY00 commented Mar 26, 2025 •
edited by bedevere-app bot
Loading

Bug report

Bug description:

2950bc5 inadvertently caused -pydebug to no longer be appended to pybuilddir.txt.

Since the WASM build scripts look for it on the build-python's pybuilddir.txt to decide whether or not to configure the host with --with-pydebug, they stopped honoring the build-python configuration.

I noticed this when I unintentionally fixed it in GH-131761, which uncovered another issue, GH-130397.

CPython versions tested on:

3.14, CPython main branch

Operating systems tested on:

No response

Linked PRs
@FFY00 FFY00 added type-bug An unexpected behavior, bug, or error build The build process and cross-build OS-wasi topic-sysconfig 3.14 bugs and security fixes labels Mar 26, 2025
This was referenced Mar 26, 2025
Closed
Open
@FFY00 FFY00 changed the title WASM build scripts don't honor --with-pydebug from build-python due to sysconfig regression WASM build scripts don't honor --with-pydebug from build-python due to a sysconfig regression Mar 26, 2025
@FFY00 FFY00 mentioned this issue Apr 1, 2025
Closed
@brettcannon brettcannon mentioned this issue Apr 21, 2025
Closed
@brettcannon
Copy link
Member

I think it's fine to call the build Python and just have it exit with 1 or 0 based on whether it's a debug build to avoid any future regressions: python -c "import sys; sys.exit(hasattr(sys, 'gettotalrefcount'))".

@bedevere-app bedevere-app bot mentioned this issue Apr 30, 2025
Merged
@brettcannon brettcannon self-assigned this Apr 30, 2025
@brettcannon
Copy link
Member

I have a PR up at #133219 which fixes the issue in a permanent way. I have it labeled as DO-NOT-MERGE until #131770 is fixed.

brettcannon added a commit to brettcannon/cpython that referenced this issue May 14, 2025
@brettcannon
pythonGH-131769: fix detecting a pydebug build of the build Python wh…
66362c5 
…en building for WASI
@bedevere-app bedevere-app bot mentioned this issue May 14, 2025
Merged
@brettcannon brettcannon added the 3.15 new features, bugs and security fixes label May 14, 2025
@brettcannon
Copy link
Member

I now have a PR for main and one for 3.14 ready to go once debug builds pass the test suite again.

brettcannon added a commit that referenced this issue May 22, 2025
@brettcannon
GH-131769: fix detecting a pydebug build of the build Python when bui…
2da2be4 
…lding for WASI (GH-134015)
@brettcannon brettcannon changed the title WASM build scripts don't honor --with-pydebug from build-python due to a sysconfig regression WASM build scripts don't honour --with-pydebug from build-python due to a sysconfig regression May 22, 2025
brettcannon added a commit that referenced this issue May 22, 2025
@brettcannon
[3.14] GH-131769: fix detecting a pydebug build of the build Python w…
8f4bf15 
…hen building for WASI (GH-133219)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brettcannon brettcannon

Labels
3.14 bugs and security fixes 3.15 new features, bugs and security fixes build The build process and cross-build OS-wasi topic-sysconfig type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brettcannon @FFY00
0