8000 Include test suite name in TSAN log filename · Issue #129980 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

Include test suite name in TSAN log filename #129980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
colesbury opened this issue Feb 10, 2025 · 0 comments
Closed

Include test suite name in TSAN log filename #129980

colesbury opened this issue Feb 10, 2025 · 0 comments
Labels
tests Tests in the Lib/test dir topic-free-threading type-feature A feature request or enhancement

Comments

@colesbury
Copy link
Contributor
colesbury commented Feb 10, 2025 •
edited by bedevere-app bot
Loading

Feature or enhancement

If you run a lot of tests that log TSAN reports to a file, you are likely to get a bunch of different log files that look pretty similar. For example, something like:

tsan_log.3313980
tsan_log.3315274
...

It can be difficult to figure out which test caused the data race, especially when the reported stack trace looks generic. For example, if the race happens in _PyEval_EvalFrameDefault or some other function not tied to a specific module, it's hard to know what caused the race.

I'm proposing that we update test/libregrtest/worker.py to include the name of the test suite in the TSAN log filename. For example, the log files would instead look like:

tsan_log.test.test_asyncio.test_sendfile.3315095
tsan_log.test__interpchannels.3313611

This makes it easier to find the test that triggered the race.

Linked PRs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tests Tests in the Lib/test dir topic-free-threading type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@colesbury
0