8000 Missing whitespaces when using `Py_CheckRecursiveCall` & co · Issue #126035 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

Missing whitespaces when using Py_CheckRecursiveCall & co #126035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
picnixz opened this issue Oct 27, 2024 · 1 comment
Closed

Missing whitespaces when using Py_CheckRecursiveCall & co #126035

picnixz opened this issue Oct 27, 2024 · 1 comment
Labels
3.12 only security fixes 3.13 bugs and security fixes 3.14 bugs and security fixes extension-modules C modules in the Modules dir type-bug An unexpected behavior, bug, or error

Comments

@picnixz
Copy link
Member
picnixz commented Oct 27, 2024 •
edited by bedevere-app bot
Loading

Bug report

Bug description:

The message must be prefixed by a whitespace since _Py_CheckRecursiveCall directly appends them to "maximum recursion depth exceeded":

cpython/Python/ceval.c

Lines 329 to 335 in dc76a4a

if (tstate->c_recursion_remaining <= 0) {
tstate->recursion_headroom++;
_PyErr_Format(tstate, PyExc_RecursionError,
"maximum recursion depth exceeded%s",
where);
tstate->recursion_headroom--;
++tstate->c_recursion_remaining;
.

Alternatively, we could make it so that a whitespace is automatically added and strip leading whitespaces if the "where" is the empty string (we wouldn't strip whitespaces in custom messages though I think).

For now, I'll just add the missing whitespaces where it should be.

CPython versions tested on:

CPython main branch

Operating systems tested on:

No response

Linked PRs
@picnixz picnixz added the type-bug An unexpected behavior, bug, or error label Oct 27, 2024
@bedevere-app bedevere-app bot mentioned this issue Oct 27, 2024
Merged
@picnixz picnixz added extension-modules C modules in the Modules dir 3.12 only security fixes 3.14 bugs and security fixes 3.13 bugs and security fixes labels Oct 27, 2024
erlend-aasland pushed a commit that referenced this issue Oct 27, 2024
@picnixz
gh-126035: add missing whitespace to *Py_EnterRecursiveCall() messages (
19e93e2 
#126036)
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Oct 27, 2024
@picnixz @miss-islington
pythongh-126035: add missing whitespace to *Py_EnterRecursiveCall() m…
2d221ee 
…essages (pythonGH-126036)

(cherry picked from commit 19e93e2)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Oct 27, 2024
@picnixz @miss-islington
pythongh-126035: add missing whitespace to *Py_EnterRecursiveCall() m…
1fde48e 
…essages (pythonGH-126036)

(cherry picked from commit 19e93e2)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
This was referenced Oct 27, 2024
Merged
Merged
erlend-aasland pushed a commit that referenced this issue Oct 27, 2024
@miss-islington @picnixz
[3.12] gh-126035: add missing whitespace to *Py_EnterRecursiveCall() …
9f35fbc 
…messages (GH-126036) (#126059)

(cherry picked from commit 19e93e2)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
erlend-aasland pushed a commit that referenced this issue Oct 27, 2024
@miss-islington @picnixz
[3.13] gh-126035: add missing whitespace to *Py_EnterRecursiveCall() …
97c2e6a 
…messages (GH-126036) (#126058)

(cherry picked from commit 19e93e2)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@picnixz
Copy link
Member Author
picnixz commented Oct 27, 2024 •
edited
Loading

Closing since completed and backported.

@picnixz picnixz closed this as completed Oct 27, 2024
picnixz added a commit to picnixz/cpython that referenced this issue Dec 8, 2024
@picnixz
pythongh-126035: add missing whitespace to *Py_EnterRecursiveCall() m…
0af323e 
…essages (python#126036)
ebonnal pushed a commit to ebonnal/cpython that referenced this issue Jan 12, 2025
@picnixz @ebonnal
pythongh-126035: add missing whitespace to *Py_EnterRecursiveCall() m…
7266b6f 
…essages (python#126036)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.12 only security fixes 3.13 bugs and security fixes 3.14 bugs and security fixes extension-modules C modules in the Modules dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@picnixz
0