8000 Some weird `make test` behavior · Issue #125669 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

Some weird make test behavior #125669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
warsaw opened this issue Oct 17, 2024 · 4 comments
Closed

Some weird make test behavior #125669

warsaw opened this issue Oct 17, 2024 · 4 comments
Labels
build The build process and cross-build infra CI, GitHub Actions, buildbots, Dependabot, etc. tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error

Comments

@warsaw
Copy link
Member
warsaw commented Oct 17, 2024 •
edited by bedevere-app bot
Loading

Bug report

Bug description:

To varying degrees, this affects the 3.12, 3.13, and main branches. Other branches are also probably affected but I haven't tested them. They aren't showstoppers, but they are annoying.

  1. make test breaks the terminal. All input is hidden until you run the reset command.
  2. Tcl/Tk tests hijack keyboard input. This is doesn't seem to affect 3.12, moderately affects 3.13, and really breaks on main. Essentially the tests pop up tons of windows, lots of stuff happens in those windows, and while that test is running, the desktop is largely unusable. You can get some mouse events through, but no keyboard events. It's especially bad with main - you basically can't get anything done until the tests complete.

CPython versions tested on:

CPython main branch

Operating systems tested on:

macOS

Linked PRs
@warsaw warsaw added the type-bug An unexpected behavior, bug, or error label Oct 17, 2024
@brandtbucher
Copy link
Member

I'm definitely in favor of changing this. I use make test locally, and it's become increasingly frustrating to try to do anything while tests are running. If people really need to test GUI stuff locally like this, maybe we can provide them with an additional make target.

@tomasr8
8000 Copy link
Member
tomasr8 commented Oct 18, 2024

To turn off all GUI tests, you can disable the gui resource: EXTRATESTOPTS="-uall,-gui" make test, though maybe it should be the default for make test?

sobolevn added a commit to sobolevn/cpython that referenced this issue Oct 19, 2024
@sobolevn
pythongh-125669: Do not run -ugui tests by default on make test
0845969
sobolevn added a commit to sobolevn/cpython that referenced this issue Oct 19, 2024
@sobolevn
pythongh-125669: Do not run -ugui tests by default on make test
8fb28f0
@bedevere-app bedevere-app bot mentioned this issue Oct 19, 2024
Merged
@sobolevn
Copy link
Member

I proposed changing the --fast-ci definition to not spawn these windows: #125730

@picnixz picnixz added tests Tests in the Lib/test dir build The build process and cross-build infra CI, GitHub Actions, buildbots, Dependabot, etc. labels Oct 21, 2024
sobolevn added a commit that referenced this issue Oct 30, 2024
@sobolevn
gh-125669: Do not run -ugui tests by default on make test (#125730)
1f16df4 
Adds `make ci` target for use in CI and keeping `make test` for the local development.
@sobolevn
Copy link
Member

Now we have make ci for CIs that will run GUI tests and make test won't by default.
Use make test TESTOPTS="-ugui" if you still want to run GUI tests and use make test.

picnixz pushed a commit to picnixz/cpython that referenced this issue Dec 8, 2024
@sobolevn @picnixz
pythongh-125669: Do not run -ugui tests by default on make test (p…
64213b2 
…ython#125730)

Adds `make ci` target for use in CI and keeping `make test` for the local development.
ebonnal pushed a commit to ebonnal/cpython that referenced this issue Jan 12, 2025
@sobolevn @ebonnal
pythongh-125669: Do not run -ugui tests by default on make test (p…
cc0a07f 
…ython#125730)

Adds `make ci` target for use in CI and keeping `make test` for the local development.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build The build process and cross-build infra CI, GitHub Actions, buildbots, Dependabot, etc. tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@warsaw @sobolevn @tomasr8 @picnixz @brandtbucher
0