8000 Make `ctrl-c` interrupt `threading.Lock.acquire()` on Windows · Issue #125541 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

Make ctrl-c interrupt threading.Lock.acquire() on Windows #125541

New issue

Have 8000 a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
colesbury opened this issue Oct 15, 2024 · 2 comments
Closed

Make ctrl-c interrupt threading.Lock.acquire() on Windows #125541

colesbury opened this issue Oct 15, 2024 · 2 comments
Labels
OS-windows type-feature A feature request or enhancement

Comments

@colesbury
Copy link
Contributor
colesbury commented Oct 15, 2024 •
edited by bedevere-app bot
Loading

Feature or enhancement

Since Python 3.2, pressing ctrl-c (SIGINT) interrupts threading.Lock.acquire() on POSIX platforms, including Linux and macOS. However, this does not work on Windows.

Now that threading.Lock and threading.RLock use PyMutex and _PyRecursiveMutex internally, this should be a lot easier to implement efficiently.

See also #125058

cc @pitrou @zooba @gpshead

Linked PRs
@colesbury colesbury added type-feature A feature request or enhancement OS-windows labels Oct 15, 2024
@pitrou
Copy link
Member
pitrou commented Oct 15, 2024

You mean here

cpython/Python/parking_lot.c

Line 114 in aac89b5

wait = WaitForSingleObjectEx(sema->platform_sem, millis, FALSE);
?

@colesbury
Copy link
Contributor Author

Yes, we can use WaitForMultipleObjectsEx() with _PyOS_SigintEvent() there without performance implications because that is the slow path that's only taken if the thread is about to block.

colesbury added a commit to colesbury/cpython that referenced this issue Oct 15, 2024
@colesbury
pythongh-125541: Make Ctrl-C interrupt threading.Lock.acquire() on …
43acec1 
…Windows
colesbury added a commit to colesbury/cpython that referenced this issue Oct 15, 2024
@colesbury
pythongh-125541: Make Ctrl-C interrupt threading.Lock.acquire() on …
2c47487 
…Windows
colesbury added a commit to colesbury/cpython that referenced this issue Oct 15, 2024
@colesbury
pythongh-125541: Make Ctrl-C interrupt threading.Lock.acquire() on …
8b3e7ae 
…Windows
colesbury added a commit to colesbury/cpython that referenced this issue Oct 15, 2024
@colesbury
pythongh-125541: Make Ctrl-C interrupt threading.Lock.acquire() on …
974e47e 
…Windows
colesbury added a commit to colesbury/cpython that referenced this issue Oct 15, 2024
@colesbury
pythongh-125541: Make Ctrl-C interrupt threading.Lock.acquire() on …
ff0455e 
…Windows
colesbury added a commit to colesbury/cpython that referenced this issue Oct 15, 2024
@colesbury
pythongh-125541: Make Ctrl-C interrupt threading.Lock.acquire() on …
25b6383 
…Windows
colesbury added a commit to colesbury/cpython that referenced this issue Oct 15, 2024
@colesbury
pythongh-125541: Make Ctrl-C interrupt threading.Lock.acquire() on …
e04866c 
…Windows
@bedevere-app bedevere-app bot mentioned this issue Oct 15, 2024
Merged
pitrou pushed a commit that referenced this issue Oct 17, 2024
@colesbury
gh-125541: Make Ctrl-C interrupt threading.Lock.acquire() on Windows (
d8c8648 
#125546)
ebonnal pushed a commit to ebonnal/cpython that referenced this issue Jan 12, 2025
@colesbury @ebonnal
pythongh-125541: Make Ctrl-C interrupt threading.Lock.acquire() on …
b37681a 
…Windows (python#125546)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
OS-windows type-feature A feature request or enhancement
Projects
Threading issues 🧵
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@colesbury @pitrou
0