8000 avoid bare except: in stdlib · Issue #125522 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

avoid bare except: in stdlib #125522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
iritkatriel opened this issue Oct 15, 2024 · 2 comments
Open

avoid bare except: in stdlib #125522

iritkatriel opened this issue Oct 15, 2024 · 2 comments
Labels
stdlib Python modules in the Lib dir

Comments

@iritkatriel
Copy link
Member
iritkatriel commented Oct 15, 2024 •
edited by bedevere-app bot
Loading

Bare excepts are best avoided, this issue is to reduce their use in the stdlib. It is not the intention to blindly replace them by except BaseException:, or to religiously purge all of them, but just to review them and avoid where it's feasible to do so.

(see also #125514).

Linked PRs
@bedevere-app bedevere-app bot mentioned this issue Oct 15, 2024
Merged
@ZeroIntensity ZeroIntensity added the stdlib Python modules in the Lib dir label Oct 15, 2024
iritkatriel added a commit that referenced this issue Oct 15, 2024
@iritkatriel
gh-125522 : add explicit exception types to bare excepts in tests (#1…
e97910c 
…25523)
iritkatriel added a commit to iritkatriel/cpython that referenced this issue Oct 15, 2024
@iritkatriel
pythongh-125522: rewrite test_math.testTan to clarify intention
1340811
@bedevere-app bedevere-app bot mentioned this issue Oct 15, 2024
Merged
iritkatriel added a commit that referenced this issue Oct 19, 2024
@iritkatriel
gh-125522: Fix bare except in test_math.testTan (#125544)
4b421e8
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Oct 19, 2024
@iritkatriel @miss-islington
pythongh-125522: Fix bare except in test_math.testTan (pythonGH-125544)
1309a0a 
(cherry picked from commit 4b421e8)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
@bedevere-app bedevere-app bot mentioned this issue Oct 19, 2024
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Oct 19, 2024
@iritkatriel @miss-islington
pythongh-125522: Fix bare except in test_math.testTan (pythonGH-125544)
11114c8 
(cherry picked from commit 4b421e8)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
@bedevere-app bedevere-app bot mentioned this issue Oct 19, 2024
Merged
iritkatriel added a commit that referenced this issue Oct 19, 2024
@miss-islington @iritkatriel
[3.12] gh-125522: Fix bare except in test_math.testTan (GH-125544) (#…
5f6e112 
…125727)

gh-125522: Fix bare except in test_math.testTan (GH-125544)
(cherry picked from commit 4b421e8)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
iritkatriel added a commit that referenced this issue Oct 19, 2024
@miss-islington @iritkatriel
[3.13] gh-125522: Fix bare except in test_math.testTan (GH-125544) (#…
96db216 
…125726)

gh-125522: Fix bare except in test_math.testTan (GH-125544)
(cherry picked from commit 4b421e8)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
@simple-is-great
Copy link
Contributor

I'll take a look :)

simple-is-great added a commit to simple-is-great/cpython that referenced this issue Nov 2, 2024
@simple-is-great
pythongh-125522: Fix bare except in test_zlib.test_flushes
8bbd858
@bedevere-app bedevere-app bot mentioned this issue Nov 2, 2024
Merged
corona10 pushed a commit that referenced this issue Nov 2, 2024
@simple-is-great
gh-125522: Remove bare except in test_zlib.test_flushes (gh-126321)
cfb1b2f
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Nov 2, 2024
@simple-is-great @miss-islington
pythongh-125522: Remove bare except in test_zlib.test_flushes (python…
46db2ce 
…gh-126321)

(cherry picked from commit cfb1b2f)

Co-authored-by: simple-is-great <103080930+simple-is-great@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Nov 2, 2024
@simple-is-great @miss-islington
pythongh-125522: Remove bare except in test_zlib.test_flushes (python…
09e10c0 
…gh-126321)

(cherry picked from commit cfb1b2f)

Co-authored-by: simple-is-great <103080930+simple-is-great@users.noreply.github.com>
This was referenced Nov 2, 2024
Merged
Merged
corona10 pushed a commit that referenced this issue Nov 2, 2024
@miss-islington @simple-is-great
[3.12] gh-125522: Remove bare except in test_zlib.test_flushes (gh-12…
eecea8f 
…6321) (gh-126328)

gh-125522: Remove bare except in test_zlib.test_flushes (gh-126321)
(cherry picked from commit cfb1b2f)

Co-authored-by: simple-is-great <103080930+simple-is-great@users.noreply.github.com>
corona10 pushed a commit that referenced this issue Nov 2, 2024
@miss-islington @simple-is-great
[3.13] gh-125522: Remove bare except in test_zlib.test_flushes (gh-12…
79ec946 
…6321) (gh-126327)

gh-125522: Remove bare except in test_zlib.test_flushes (gh-126321)
(cherry picked from commit cfb1b2f)

Co-authored-by: simple-is-great <103080930+simple-is-great@users.noreply.github.com>
picnixz pushed a commit to picnixz/cpython that referenced this issue Dec 8, 2024
@simple-is-great @picnixz
pythongh-125522: Remove bare except in test_zlib.test_flushes (python…
0c04462 
…gh-126321)
ebonnal pushed a commit to ebonnal/cpython that referenced this issue Jan 12, 2025
@iritkatriel @ebonnal
pythongh-125522: Fix bare except in test_math.testTan (python#125544)
e9a0273
ebonnal pushed a commit to ebonnal/cpython that referenced this issue Jan 12, 2025
@simple-is-great @ebonnal
pythongh-125522: Remove bare except in test_zlib.test_flushes (python…
68555d4 
…gh-126321)
@bedevere-app bedevere-app bot mentioned this issue Jan 19, 2025
Merged
iritkatriel pushed a commit that referenced this issue Jan 29, 2025
@tomasr8
gh-125522: Fix bare except in test_uuid (#129018)
a1a4e9f
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jan 29, 2025
@tomasr8 @miss-islington
pythongh-125522: Fix bare except in test_uuid (pythonGH-129018)
60011ce 
(cherry picked from commit a1a4e9f)

Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jan 29, 2025
@tomasr8 @miss-islington
pythongh-125522: Fix bare except in test_uuid (pythonGH-129018)
9329fed 
(cherry picked from commit a1a4e9f)

Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
@bedevere-app bedevere-app bot mentioned this issue Jan 29, 2025
Merged
@bedevere-app bedevere-app bot mentioned this issue Jan 29, 2025
Merged
iritkatriel pushed a commit that referenced this issue Jan 29, 2025
@miss-islington @tomasr8
[3.12] gh-125522: Fix bare except in test_uuid (GH-129018) (#129456)
c0ae83a 
gh-125522: Fix bare except in `test_uuid` (GH-129018)
(cherry picked from commit a1a4e9f)

Co-authored-by: Tomas R <tomas.roun8@gmail.com>
iritkatriel pushed a commit that referenced this issue Jan 29, 2025
@miss-islington @tomasr8
[3.13] gh-125522: Fix bare except in test_uuid (GH-129018) (#129455)
8b4a0d6 
gh-125522: Fix bare except in `test_uuid` (GH-129018)
(cherry picked from commit a1a4e9f)

Co-authored-by: Tomas R <tomas.roun8@gmail.com>
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this issue Feb 7, 2025
@tomasr8 @srinivasreddy
pythongh-125522: Fix bare except in test_uuid (python#129018)
55a4f49
@StanFromIreland
Copy link
Contributor

Note there already exists a bug for all of the cases in idlelib: #59518

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stdlib Python modules in the Lib dir
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@iritkatriel @ZeroIntensity @StanFromIreland @simple-is-great
0