8000 Build failure on MSVC 1935 with JIT enabled · Issue #125207 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

Build failure on MSVC 1935 with JIT enabled #125207

New issue

Have a question about this project? Sig 10000 n up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mdboom opened this issue Oct 9, 2024 · 0 comments
Closed

Build failure on MSVC 1935 with JIT enabled #125207

mdboom opened this issue Oct 9, 2024 · 0 comments
Assignees
@mdboom
Labels
OS-windows type-bug An unexpected behavior, bug, or error

Comments

@mdboom
Copy link
Contributor
mdboom commented Oct 9, 2024 •
edited by bedevere-app bot
Loading

Bug report

Bug description:

Building on MSVC 1935 currently fails when building with the JIT, because that compiler does not support empty array initializers ({}).

PCbuild\build.bat --experimental-jit -c Release

...

C:\actions-runner\_work\benchmarking\benchmarking\cpython\PCbuild\obj\314amd64_PGInstrument\pythoncore\jit_stencils.h(23145,68): error C2059: syntax error: '}' (compiling source file ..\Python\jit.c) [C:\actions-runner\_work\benchmarking\benchmarking\cpython\PCbuild\pythoncore.vcxproj]

This line in jit_stencils.h looks like:

static const StencilGroup trampoline = {emit_trampoline, 273, 24, {}};
                                                                   ^

This was introduced recently in #123872. All of the uses of empty initializers should use {0} instead.

CPython versions tested on:

CPython main branch

Operating systems tested on:

Windows

Linked PRs
@mdboom mdboom added the type-bug An unexpected behavior, bug, or error label Oct 9, 2024
@mdboom mdboom self-assigned this Oct 9, 2024
mdboom added a commit to mdboom/cpython that referenced this issue Oct 9, 2024
@mdboom
pythongh-125207: Use {0} array initializers
51618b6
@bedevere-app bedevere-app bot mentioned this issue Oct 9, 2024
Merged
mdboom added a commit that referenced this issue Oct 18, 2024
@mdboom
gh-125207: Fix MSVC 1935 build with JIT (#125209)
c8fd4b1 
* gh-125207: Use {0} array initializers

* Simplify, as suggested in PR

* Revert change to explicitly specify length
@mdboom mdboom closed this as completed Oct 18, 2024
pablogsal pushed a commit to pablogsal/cpython that referenced this issue Oct 18, 2024
@mdboom @pablogsal
pythongh-125207: Fix MSVC 1935 build with JIT (python#125209)
410c2c4 
* pythongh-125207: Use {0} array initializers

* Simplify, as suggested in PR

* Revert change to explicitly specify length

Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
pablogsal pushed a commit to pablogsal/cpython that referenced this issue Oct 21, 2024
@mdboom @pablogsal
pythongh-125207: Fix MSVC 1935 build with JIT (python#125209)
9f3e194 
* pythongh-125207: Use {0} array initializers

* Simplify, as suggested in PR

* Revert change to explicitly specify length

Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
pablogsal pushed a commit to pablogsal/cpython that referenced this issue Oct 21, 2024
@mdboom @pablogsal
pythongh-125207: Fix MSVC 1935 build with JIT (python#125209)
1e098e9 
* pythongh-125207: Use {0} array initializers

* Simplify, as suggested in PR

* Revert change to explicitly specify length

Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
ebonnal pushed a commit to ebonnal/cpython that referenced this issue Jan 12, 2025
@mdboom @ebonnal
pythongh-125207: Fix MSVC 1935 build with JIT (python#125209)
409527f 
* pythongh-125207: Use {0} array initializers

* Simplify, as suggested in PR

* Revert change to explicitly specify length
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mdboom mdboom

Labels
OS-windows type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mdboom
0