8000 Use the normal code path for breakpoint commands in pdb · Issue #124400 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

Use the normal code path for breakpoint commands in pdb #124400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gaogaotiantian opened this issue Sep 23, 2024 · 0 comments
Closed

Use the normal code path for breakpoint commands in pdb #124400

gaogaotiantian opened this issue Sep 23, 2024 · 0 comments
Labels
type-feature A feature request or enhancement

Comments

@gaogaotiantian
Copy link
Member
gaogaotiantian commented Sep 23, 2024 •
edited by github-actions bot
Loading

Feature or enhancement

Proposal:

Currently the structure to support breakpoint commands is too heavy. We need to keep self.commands_doprompt and self.commands_silent which are not necessary. Also bp_commands now use its own loop to execute commands - we should avoid this as much as possible because this is a duplicate path that may have dark corners. For example, if in the future we have commands that insert commands in the beginning of the cmdqueue.

We should avoid having many exceptions for this command and use the existing structure to run the command in breakpoint commands.

Has this already been discussed elsewhere?

This is a minor feature, which does not need previous discussion elsewhere

Links to previous discussion of this feature:

No response

Linked PRs
@gaogaotiantian gaogaotiantian added the type-feature A feature request or enhancement label Sep 23, 2024
@bedevere-app bedevere-app bot mentioned this issue Sep 23, 2024
Merged
gaogaotiantian added a commit that referenced this issue Sep 29, 2024
@gaogaotiantian @iritkatriel
gh-124400: Use the normal command path for breakpoint commands (#124401)
b577460 
Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gaogaotiantian
0