8000 ``test_asyncio.test_base_events`` leaks references in free-threaded build · Issue #124068 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

test_asyncio.test_base_events leaks references in free-threaded build #124068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Eclips4 opened this issue Sep 13, 2024 · 3 comments
Closed

test_asyncio.test_base_events leaks references in free-threaded build #124068

Eclips4 opened this issue Sep 13, 2024 · 3 comments
Labels
tests Tests in the Lib/test dir topic-free-threading type-bug An unexpected behavior, bug, or error

Comments

@Eclips4
Copy link
Member
Eclips4 commented Sep 13, 2024 •
edited by bedevere-app bot
Loading

Bug report

Bug description:

eclips4@nixos ~/p/p/cpython (main)> ./python -m test -R 3:3 test_asyncio.test_base_events
Using random seed: 315532800
0:00:00 load avg: 7.88 Run 1 test sequentially in a single process
0:00:00 load avg: 7.88 [1/1] test_asyncio.test_base_events
beginning 6 repetitions. Showing number of leaks (. for 0 or less, X for 10 or more)
123:456
XX3 333
test_asyncio.test_base_events leaked [3, 3, 3] references, sum=9
test_asyncio.test_base_events failed (reference leak)

== Tests result: FAILURE ==

1 test failed:
    test_asyncio.test_base_events

Total duration: 18.4 sec
Total tests: run=111
Total test files: run=1/1 failed=1
Result: FAILURE

CPython versions tested on:

CPython main branch

Operating systems tested on:

Linux

Linked PRs
@Eclips4 Eclips4 added type-bug An unexpected behavior, bug, or error tests Tests in the Lib/test dir topic-free-threading labels Sep 13, 2024
@Eclips4
Copy link
Member Author
Eclips4 commented Sep 13, 2024

Bisected to 8810e28

@picnixz
Copy link
Member
picnixz commented Sep 13, 2024 •
edited
Loading

cc @Fidget-Spinner @colesbury @markshannon (technically, @me as well since I've been involved :'))

@colesbury
Copy link
Contributor

I'll take a look. I saw something similar when working on #124026 with a reference leak involving generators/coroutines and exceptions frames.

colesbury added a commit to colesbury/cpython that referenced this issue Sep 13, 2024
@colesbury
pythongh-124068: Fix reference leak with generators in the free-threa…
8d220b7 
…ded build

If the generator is already cleared, then most fields in the
generator's frame are not valid other than f_executable. The invalid
fields may contain dangling pointers and should not be used.
@bedevere-app bedevere-app bot mentioned this issue Sep 13, 2024
Merged
colesbury added a commit to colesbury/cpython that referenced this issue Sep 13, 2024
colesbury added a commit that referenced this issue Sep 14, 2024
@colesbury
gh-124068: Fix reference leak with generators in the free-threaded bu…
b02301f 
…ild (#124069)

If the generator is already cleared, then most fields in the
generator's frame are not valid other than f_executable. The invalid
fields may contain dangling pointers and should not be used.
@Eclips4 Eclips4 closed this as completed Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tests Tests in the Lib/test dir topic-free-threading type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@colesbury @picnixz @Eclips4
0