8000 asyncio module state should be locked with mutexes in free-threaded builds · Issue #121621 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content
8000

asyncio module state should be locked with mutexes in free-threaded builds #121621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Fidget-Spinner opened this issue Jul 11, 2024 · 2 comments
Closed

asyncio module state should be locked with mutexes in free-threaded builds #121621

Fidget-Spinner opened this issue Jul 11, 2024 · 2 comments
Labels
topic-free-threading type-feature A feature request or enhancement

Comments

@Fidget-Spinner
Copy link
Member
Fidget-Spinner commented Jul 11, 2024 •
edited by bedevere-app bot
Loading

Feature or enhancement

Proposal:

Please see issue title.

Has this already been discussed elsewhere?

No response given

Links to previous discussion of this feature:

No response

Linked PRs
@Fidget-Spinner Fidget-Spinner added type-feature A feature request or enhancement topic-free-threading labels Jul 11, 2024
@bedevere-app bedevere-app bot mentioned this issue Jul 11, 2024
Merged
@colesbury
Copy link
Contributor

I think we also want to make enter_task, leave_task, and swap_current_task behave atomically. For example, enter_task makes two dict API calls that individually lock the dictionary, but the combined operation isn't atomic.

I can think of two strategies for this:

  1. Try to replace multiple API calls with a single call. For example, I think enter_task may be able to use PyDict_SetDefaultRef and leave_task may be able to use _PyDict_DelItemIf with some modifications.
  2. Use a critical section to lock the dict and use the "lock held" variants.

@bedevere-app bedevere-app bot mentioned this issue Jul 13, 2024
Merged
kumaraditya303 added a commit that referenced this issue Jul 14, 2024
@Fidget-Spinner @kumaraditya303
gh-121621: Use PyMutex for writes to asyncio state (#121622)
5d6861a 
Co-authored-by: Kumar Aditya <kumaraditya@python.org>
colesbury pushed a commit to colesbury/cpython that referenced this issue Jul 14, 2024
@Fidget-Spinner @kumaraditya303 @colesbury
[3.13] pythongh-121621: Use PyMutex for writes to asyncio state (pyth…
e28808d 
…onGH-121622)

(cherry picked from commit 5d6861a)

Co-authored-by: Ken Jin <kenjin@python.org>
Co-authored-by: Kumar Aditya <kumaraditya@python.org>
@bedevere-app bedevere-app bot mentioned this issue Jul 14, 2024
Merged
kumaraditya303 added a commit that referenced this issue Jul 15, 2024
@colesbury @Fidget-Spinner @kumaraditya303
[3.13] gh-121621: Use PyMutex for writes to asyncio state (GH-121622) (…
a2a4f5e 
…#121774)

(cherry picked from commit 5d6861a)

Co-authored-by: Ken Jin <kenjin@python.org>
Co-authored-by: Kumar Aditya <kumaraditya@python.org>
Fidget-Spinner added a commit that referenced this issue Jul 16, 2024
@Fidget-Spinner
gh-121621: Move asyncio running loop to thread state (GH-121695)
69c68de
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jul 16, 2024
@Fidget-Spinner @miss-islington
pythongh-121621: Move asyncio running loop to thread state (pythonGH-…
efea984 
…121695)

(cherry picked from commit 69c68de)

Co-authored-by: Ken Jin <kenjin@python.org>
@bedevere-app bedevere-app bot mentioned this issue Jul 16, 2024
Merged
Fidget-Spinner added a commit that referenced this issue Jul 16, 2024
@miss-islington @Fidget-Spinner
[3.13] gh-121621: Move asyncio running loop to thread state (GH-121695)…
06d76c4 
… (GH-121864)

gh-121621: Move asyncio running loop to thread state (GH-121695)
(cherry picked from commit 69c68de)

Co-authored-by: Ken Jin <kenjin@python.org>
estyxx pushed a commit to estyxx/cpython that referenced this issue Jul 17, 2024
@Fidget-Spinner @kumaraditya303 @estyxx
pythongh-121621: Use PyMutex for writes to asyncio state (python#121622)
9bd2dd2 
Co-authored-by: Kumar Aditya <kumaraditya@python.org>
@bedevere-app bedevere-app bot mentioned this issue Jul 17, 2024
Closed
colesbury added a commit to colesbury/cpython that referenced this issue Jul 17, 2024
@colesbury
pythongh-121621: Move asyncio_running_loop to private struct
d623558 
This avoids changing the ABI and keeps the field in the private struct.
@bedevere-app bedevere-app bot mentioned this issue Jul 17, 2024
Merged
Yhg1s pushed a commit that referenced this issue Jul 17, 2024
@colesbury
gh-121621: Move asyncio_running_loop to private struct (#121939)
81fd625 
This avoids changing the ABI and keeps the field in the private struct.
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jul 17, 2024
@colesbury @miss-islington
pythongh-121621: Move asyncio_running_loop to private struct (pythonG…
10b083d 
…H-121939)

This avoids changing the ABI and keeps the field in the private struct.
(cherry picked from commit 81fd625)

Co-authored-by: Sam Gross <colesbury@gmail.com>
@bedevere-app bedevere-app bot mentioned this issue Jul 17, 2024
Merged
Yhg1s pushed a commit that referenced this issue Jul 18, 2024
@miss-islington @colesbury
[3.13] gh-121621: Move asyncio_running_loop to private struct (GH-121939
afa5321 
) (#121943)

gh-121621: Move asyncio_running_loop to private struct (GH-121939)

This avoids changing the ABI and keeps the field in the private struct.
(cherry picked from commit 81fd625)

Co-authored-by: Sam Gross <colesbury@gmail.com>
colesbury added a commit to colesbury/cpython that referenced this issue Jul 19, 2024
@colesbury
pythongh-121621: Disable asyncio freelist in free-threaded build
c1d4f44 
The futureobj freelist isn't thread-safe. We intend to re-enable the
freelist in a thread-safe way for 3.14 (but not 3.13).
@bedevere-app bedevere-app bot mentioned this issue Jul 19, 2024
Merged
colesbury added a commit that referenced this issue Jul 19, 2024
@colesbury
gh-121621: Disable asyncio freelist in free-threaded build (#122046)
9724820 
The futureobj freelist isn't thread-safe. We intend to re-enable the
freelist in a thread-safe way for 3.14 (but not 3.13).
colesbury added a commit to colesbury/cpython that referenced this issue Jul 19, 2024
@colesbury
[3.13] pythongh-121621: Disable asyncio freelist in free-threaded bui…
022e244 
…ld (pythonGH-122046)

The futureobj freelist isn't thread-safe. We intend to re-enable the
freelist in a thread-safe way for 3.14 (but not 3.13).
(cherry picked from commit 9724820)

Co-authored-by: Sam Gross <colesbury@gmail.com>
@bedevere-app bedevere-app bot mentioned this issue Jul 19, 2024
Merged
colesbury added a commit that referenced this issue Jul 19, 2024
@colesbury
[3.13] gh-121621: Disable asyncio freelist in free-threaded build (GH…
f3c79cb 
…-122046) (#122048)

The futureobj freelist isn't thread-safe. We intend to re-enable the
freelist in a thread-safe way for 3.14 (but not 3.13).
(cherry picked from commit 9724820)
@Fidget-Spinner
Copy link
Member Author

Fixed.

kumaraditya303 added a commit that referenced this issue Dec 18, 2024
@kumaraditya303
gh-121621: clear running loop early in asyncio (#128004)
8a433b6
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this issue Jan 8, 2025
@kumaraditya303 @srinivasreddy
pythongh-121621: clear running loop early in asyncio (python#128004)
1cfa486
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic-free-threading type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@colesbury @Fidget-Spinner
0