`select.poll()` objects are not thread-safe in the free-threaded build #121592

colesbury · 2024-07-10T18:52:44Z

Bug report

The polling objects returned by select.poll and related functions are not thread-safe in the free-threaded build.

The fix might be as simple as adding critical sections to the functions on pollObject or it may require more work.

The following test exercises the thread-unsafe behavior:

./python -m test test_poll -m test_threaded_poll

Relevant object:

cpython/Modules/selectmodule.c

Lines 434 to 441 in 3ec719f

    
           typedef struct { 
        
               PyObject_HEAD 
        
               PyObject *dict; 
        
               int ufd_uptodate; 
        
               int ufd_len; 
        
               struct pollfd *ufds; 
        
               int poll_running; 
        
           } pollObject;

Linked PRs

The text was updated successfully, but these errors were encountered:

This makes select.poll() and kqueue() objects thread-safe in the free-threaded build. Note that calling close() concurrently with other functions is still not thread-safe due to races on file descriptors (pythongh-121544).

This makes select.poll() and kqueue() objects thread-safe in the free-threaded build. Note that calling close() concurrently with other functions is still not thread-safe due to races on file descriptors (gh-121544).

…ythonGH-121594) This makes select.poll() and kqueue() objects thread-safe in the free-threaded build. Note that calling close() concurrently with other functions is still not thread-safe due to races on file descriptors (pythongh-121544). (cherry picked from commit 44937d1) Co-authored-by: Sam Gross <colesbury@gmail.com>

…H-121594) (#121623) This makes select.poll() and kqueue() objects thread-safe in the free-threaded build. Note that calling close() concurrently with other functions is still not thread-safe due to races on file descriptors (gh-121544). (cherry picked from commit 44937d1) Co-authored-by: Sam Gross <colesbury@gmail.com>

…ython#121594) This makes select.poll() and kqueue() objects thread-safe in the free-threaded build. Note that calling close() concurrently with other functions is still not thread-safe due to races on file descriptors (pythongh-121544).

colesbury added type-bug An unexpected behavior, bug, or error 3.13 bugs and security fixes topic-free-threading 3.14 bugs and security fixes labels Jul 10, 2024

bedevere-app bot mentioned this issue Jul 10, 2024

gh-121592: Make select.poll() and related objects thread-safe #121594

Merged

bedevere-app bot mentioned this issue Jul 11, 2024

[3.13] gh-121592: Make select.poll() and related objects thread-safe (GH-121594) #121623

Merged

colesbury closed this as completed Jul 11, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

`select.poll()` objects are not thread-safe in the free-threaded build #121592

`select.poll()` objects are not thread-safe in the free-threaded build #121592

Uh oh!

select.poll() objects are not thread-safe in the free-threaded build #121592

select.poll() objects are not thread-safe in the free-threaded build #121592

Comments

Uh oh!

Bug report

Linked PRs

`select.poll()` objects are not thread-safe in the free-threaded build #121592

`select.poll()` objects are not thread-safe in the free-threaded build #121592