8000 Wrap some multi-line macros in ``do { ... } while(0)`` in ``symtable.c`` · Issue #119981 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

Wrap some multi-line macros in do { ... } while(0) in symtable.c #119981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
picnixz opened this issue Jun 3, 2024 · 3 comments
Closed

Wrap some multi-line macros in do { ... } while(0) in symtable.c #119981

picnixz opened this issue Jun 3, 2024 · 3 comments
Labels
type-feature A feature request or enhancement

Comments

@picnixz
Copy link
Member
picnixz commented Jun 3, 2024 •
edited by bedevere-app bot
Loading

Feature or enhancement

Proposal:

While I was implementing #119976, I observed that some macros are not guarded against possible constructions because their content is only wrapped in {} but not in the classical do { ... } while(0) construction.

For instance, the current VISIT macro sometimes requires the semi-colon and sometimes not depending on how it is used, which I find a bit confusing. I think it's preferrable to always require to add the ;.

Has this already been discussed elsewhere?

No response given

Links to previous discussion of this feature:

No response

Linked PRs
@picnixz picnixz added the type-feature A feature request or enhancement label Jun 3, 2024
@bedevere-app bedevere-app bot mentioned this issue Jun 3, 2024
Merged
vstinner pushed a commit that referenced this issue Jun 3, 2024
@picnixz
gh-119981: Use do while(0) in some symtable.c multi-line macros (#119982
153b118 
)
@sobolevn
Copy link
Member
sobolevn commented Jun 3, 2024

There are similar patterns in compile.c, maybe it is also worth taking a look? 🤔

@picnixz
Copy link
Member Author
picnixz commented Jun 3, 2024

Yes, that's a good idea. Since I was going offline in a few minutes, could you either close this issue or edit the title so that we can perhaps track other files?

@sobolevn
Copy link
Member
sobolevn commented Jun 3, 2024

I prefer to open new ones for each piece of work :)
Thanks again!

@sobolevn sobolevn closed this as completed Jun 3, 2024
mliezun pushed a commit to mliezun/cpython that referenced this issue Jun 3, 2024
@picnixz @mliezun
pythongh-119981: Use do while(0) in some symtable.c multi-line macros (…
0998c3a 
…python#119982)
@picnixz picnixz mentioned this issue Jun 4, 2024
Closed
barneygale pushed a commit to barneygale/cpython that referenced this issue Jun 5, 2024
930D
@picnixz @barneygale
pythongh-119981: Use do while(0) in some symtable.c multi-line macros (…
26671c1 
…python#119982)
@picnixz picnixz mentioned this issue Jun 18, 2024
Closed
noahbkim pushed a commit to hudson-trading/cpython that referenced this issue Jul 11, 2024
@picnixz @noahbkim
pythongh-119981: Use do while(0) in some symtable.c multi-line macros (…
eed5b1f 
…python#119982)
estyxx pushed a commit to estyxx/cpython that referenced this issue Jul 17, 2024
@picnixz @estyxx
pythongh-119981: Use do while(0) in some symtable.c multi-line macros (…
6b4bd7e 
…python#119982)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sobolevn @picnixz
0