8000 PEP 695: Name mangling leaks to surrounding scope · Issue #119395 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

PEP 695: Name mangling leaks to surrounding scope #119395

New issue

8000 Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JelleZijlstra opened this issue May 22, 2024 · 0 comments · Fixed by #119464
Closed

PEP 695: Name mangling leaks to surrounding scope #119395

JelleZijlstra opened this issue May 22, 2024 · 0 comments · Fixed by #119464
Assignees
@JelleZijlstra
Labels
3.12 only security fixes 3.13 bugs and security fixes 3.14 bugs and security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error

Comments

@JelleZijlstra
Copy link
Member
JelleZijlstra commented May 22, 2024 •
edited by bedevere-app bot
Loading

Bug report

% cat leak.py 
def f():
    __foo = 1
    class X[T]: ...
    return __foo
f()
% python3.12 leak.py
Traceback (most recent call last):
  File "/Users/jelle/py/cpython/leak.py", line 5, in <module>
    f()
  File "/Users/jelle/py/cpython/leak.py", line 4, in f
    return __foo
           ^^^^^
NameError: name '_X__foo' is not defined. Did you mean: '__foo'?

The PEP 695 implementation of generic classes turns on name mangling for the type parameter scope, but never turns it off afterwards. As a result, all code that appears syntactically after the PEP 695 scope also gets mangling applied to it.

I have a fix for this, but I believe applying it requires updating the magic number, and I'm not sure we can afford to to do that on the 3.12 branch.

Linked PRs
@JelleZijlstra JelleZijlstra added type-bug An unexpected behavior, bug, or error interpreter-core (Objects, Python, Grammar, and Parser dirs) 3.12 only security fixes 3.13 bugs and security fixes labels May 22, 2024
@bedevere-app bedevere-app bot mentioned this issue May 22, 2024
Closed
@JelleZijlstra JelleZijlstra mentioned this issue May 22, 2024
Closed
@Eclips4 Eclips4 added the 3.14 bugs and security fixes label May 22, 2024
JelleZijlstra added a commit to JelleZijlstra/cpython that referenced this issue May 23, 2024
@JelleZijlstra
pythongh-119311: Fix name mangling with PEP 695 generic classes
a43da60 
Fixes python#119311. Fixes python#119395.
@JelleZijlstra JelleZijlstra mentioned this issue May 23, 2024
Merged
@JelleZijlstra JelleZijlstra self-assigned this May 23, 2024
JelleZijlstra added a commit to JelleZijlstra/cpython that referenced this issue May 28, 2024
@JelleZijlstra
pythongh-119311: Fix name mangling with PEP 695 generic classes (pyth…
a86d032 
…on#119464)

Fixes python#119311. Fixes python#119395.

(cherry picked from commit a9a74da)
@JelleZijlstra JelleZijlstra mentioned this issue May 28, 2024
Merged
JelleZijlstra added a commit to JelleZijlstra/cpython that referenced this issue May 28, 2024
@JelleZijlstra
[3.12] pythongh-119311: Fix name mangling with PEP 695 generic classes (
2712e72 
python#119464)

Fixes python#119311. Fixes python#119395.

(cherry picked from commit a9a74da)
@JelleZijlstra JelleZijlstra mentioned this issue May 28, 2024
Merged
JelleZijlstra added a commit that referenced this issue May 28, 2024
@JelleZijlstra
[3.13] gh-119311: Fix name mangling with PEP 695 generic classes (#11…
6394a72 
…9464) (#119643)

Fixes #119311. Fixes #119395.

(cherry picked from commit a9a74da)
Yhg1s pushed a commit that referenced this issue Jun 4, 2024
@JelleZijlstra
[3.12] gh-119311: Fix name mangling with PEP 695 generic classes (#11…
dc40226 
…9464) (#119644)

* [3.12] gh-119311: Fix name mangling with PEP 695 generic classes (#119464)

Fixes #119311. Fixes #119395.

(cherry picked from commit a9a74da)
estyxx pushed a commit to estyxx/cpython that referenced this issue Jul 17, 2024
@JelleZijlstra @estyxx
pythongh-119311: Fix name mangling with PEP 695 generic classes (pyth…
c16552f 
…on#119464)

Fixes python#119311. Fixes python#119395.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JelleZijlstra JelleZijlstra

Labels
3.12 only security fixes 3.13 bugs and security fixes 3.14 bugs and security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-119311: Fix name mangling with PEP 695 generic classes JelleZijlstra/cpython
2 participants
@JelleZijlstra @Eclips4
0