8000 Improve tests for PyEval_EvalCodeEx · Issue #117694 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

Improve tests for PyEval_EvalCodeEx #117694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
serhiy-storchaka opened this issue Apr 9, 2024 · 0 comments
Closed

Improve tests for PyEval_EvalCodeEx #117694

serhiy-storchaka opened this issue Apr 9, 2024 · 0 comments
Labels
3.12 only security fixes 3.13 bugs and security fixes tests Tests in the Lib/test dir topic-C-API

Comments

@serhiy-storchaka
Copy link
Member
serhiy-storchaka commented Apr 9, 2024 •
edited by bedevere-app bot
Loading

In the discussion for #116637 I noticed that the wrapper for PyEval_EvalCodeEx unnecessary constricts types of some arguments, preventing testing handling of wrong arguments in PyEval_EvalCodeEx.

The proposed PR removes these restrictions and adds many tests for PyEval_EvalCodeEx with different types and values. It also add tests for custom locals, which were not tested before.

Linked PRs
@serhiy-storchaka serhiy-storchaka added tests Tests in the Lib/test dir topic-C-API 3.12 only security fixes 3.13 bugs and security fixes labels Apr 9, 2024
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this issue Apr 9, 2024
@serhiy-storchaka
pythongh-117694: Improve tests for PyEval_EvalCodeEx()
0305390
@bedevere-app bedevere-app bot mentioned this issue Apr 9, 2024
Merged
serhiy-storchaka added a commit that referenced this issue Apr 15, 2024
@serhiy-storchaka
gh-117694: Improve tests for PyEval_EvalCodeEx() (GH-117695)
57bdb75
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Apr 15, 2024
@serhiy-storchaka @miss-islington
pythongh-117694: Improve tests for PyEval_EvalCodeEx() (pythonGH-117695)
03cd669 
(cherry picked from commit 57bdb75)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app bedevere-app bot mentioned this issue Apr 15, 2024
Merged
serhiy-storchaka added a commit that referenced this issue Apr 15, 2024
@miss-islington @serhiy-storchaka
[3.12] gh-117694: Improve tests for PyEval_EvalCodeEx() (GH-117695) (G…
50b94b1 
…H-117884)

(cherry picked from commit 57bdb75)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
diegorusso pushed a commit to diegorusso/cpython that referenced this issue Apr 17, 2024
@serhiy-storchaka @diegorusso
pythongh-117694: Improve tests for PyEval_EvalCodeEx() (pythonGH-117695)
9ac120b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.12 only security fixes 3.13 bugs and security fixes tests Tests in the Lib/test dir topic-C-API
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@serhiy-storchaka
0