8000 http.server misleading point in doc about "text/*" mime types · Issue #117026 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

http.server misleading point in doc about "text/*" mime types #117026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
SalehDehqanpour opened this issue 8000 Mar 19, 2024 · 1 comment
Closed

http.server misleading point in doc about "text/*" mime types #117026

SalehDehqanpour opened this issue Mar 19, 2024 · 1 comment
Labels
docs Documentation in the Doc dir

Comments

@SalehDehqanpour
Copy link
Contributor
SalehDehqanpour commented Mar 19, 2024 •
edited by bedevere-app bot
Loading

Documentation

It's said in the http.server docs:

If the file’s MIME type starts with text/ the file is opened in text mode; otherwise binary mode is used.

But the code always opens file in binary mode so this is not true. The quoted sentence should be removed.

Linked PRs
@SalehDehqanpour SalehDehqanpour added the docs Documentation in the Doc dir label Mar 19, 2024
SalehDehqanpour added a commit to SalehDehqanpour/cpython that referenced this issue Mar 19, 2024
@SalehDehqanpour
docs: fix wrong sentence in SimpleHTTPRequestHandler about serving te…
3f34ac7 
…xt files

The code does not differentiate between text and binary files so the sentence should be removed from the doc. See python#117026
@SalehDehqanpour SalehDehqanpour mentioned this issue Mar 19, 2024
Merged
@serhiy-storchaka
Copy link
Member

For reference, the code was changed in 0f7cddc (bpo-839496/gh-39531).

serhiy-storchaka pushed a commit that referenced this issue May 16, 2025
@SalehDehqanpour
gh-117026: Remove outdated sentence in SimpleHTTPRequestHandler docs (G…
ea2d707 
…H-117027)

The code was changed in 0f7cddc (bpo-839496/gh-39531).
miss-islington pushed a commit to miss-islington/cpython that referenced this issue May 16, 2025
@SalehDehqanpour @miss-islington
pythongh-117026: Remove outdated sentence in SimpleHTTPRequestHandler…
be9c37b 
… docs (pythonGH-117027)

The code was changed in 0f7cddc (bpo-839496/pythongh-39531).
(cherry picked from commit ea2d707)

Co-authored-by: Saleh Dehqanpour <salehdeh76@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue May 16, 2025
@SalehDehqanpour @miss-islington
pythongh-117026: Remove outdated sentence in SimpleHTTPRequestHandler…
0d68444 
… docs (pythonGH-117027)

The code was changed in 0f7cddc (bpo-839496/pythongh-39531).
(cherry picked from commit ea2d707)

Co-authored-by: Saleh Dehqanpour <salehdeh76@gmail.com>
This was referenced May 16, 2025
Merged
Merged
serhiy-storchaka pushed a commit that referenced this issue May 16, 2025
@miss-islington @SalehDehqanpour
[3.14] gh-117026: Remove outdated sentence in SimpleHTTPRequestHandle…
7a5851d 
…r docs (GH-117027) (GH-134107)

The code was changed in 0f7cddc (bpo-839496/gh-39531).
(cherry picked from commit ea2d707)

Co-authored-by: Saleh Dehqanpour <salehdeh76@gmail.com>
serhiy-storchaka pushed a commit that referenced this issue May 16, 2025
@miss-islington @SalehDehqanpour
[3.13] gh-117026: Remove outdated sentence in SimpleHTTPRequestHandle…
4291bbe 
…r docs (GH-117027) (GH-134108)

The code was changed in 0f7cddc (bpo-839496/gh-39531).
(cherry picked from commit ea2d707)

Co-authored-by: Saleh Dehqanpour <salehdeh76@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs Documentation in the Doc dir
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@serhiy-storchaka @SalehDehqanpour
0