8000 Assertion failure in `Objects/call.c`:342: `!_PyErr_Occurred(tstate)` failed · Issue #112388 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

Assertion failure in Objects/call.c:342: !_PyErr_Occurred(tstate) failed #112388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bradlarsen opened this issue Nov 25, 2023 · 4 comments
Closed

Assertion failure in Objects/call.c:342: !_PyErr_Occurred(tstate) failed #112388

bradlarsen opened this issue Nov 25, 2023 · 4 comments
Labels
type-crash A hard crash of the interpreter, possibly with a core dump

Comments

@bradlarsen
Copy link
Contributor
bradlarsen commented Nov 25, 2023 •
edited by bedevere-app bot
Loading

Crash report

What happened?

I found some crashes when adding an additional fuzz target in #111721.

# This script fails with a C assertion failure when assertions are enabled.
#
# I ran this through Python built from source with assertions enabled:
#
#     ./configure --with-assertions --prefix "$PWD/debugbuild"
#     make -j12 altinstall
#     ./debugbuild/bin/python/crash2.py
#
# I ran this on ARM64 macOS:
#
#     Darwin dialectic.local 23.1.0 Darwin Kernel Version 23.1.0: Mon Oct  9 21:27:24 PDT 2023; root:xnu-10002.41.9~6/RELEASE_ARM64_T6000 arm64

# Input found via the fuzz target added in https://github.com/python/cpython/pull/111721, then manually minimized
s = b"with(0,,):\n\x01"

# This line fails with a C assertion failure:
#
#     fuzz_pycompile: Objects/call.c:342: PyObject *_PyObject_Call(PyThreadState *, PyObject *, PyObject *, PyObject *): Assertion `!_PyErr_Occurred(tstate)' failed.
#
compile(s, 's', 'exec')

CPython versions tested on:

CPython main branch

Operating systems tested on:

macOS

Output from running 'python -VV' on the command line:

Python 3.13.0a1+ (heads/main:3701f3bc10, Nov 24 2023, 23:05:42) [Clang 15.0.0 (clang-1500.0.40.1)]

Linked PRs
@bradlarsen bradlarsen added the type-crash A hard crash of the interpreter, possibly with a core dump label Nov 25, 2023
@bradlarsen bradlarsen mentioned this issue Nov 25, 2023
Closed
@bradlarsen
Copy link
Contributor Author

See also #112387

@bradlarsen bradlarsen mentioned this issue Nov 25, 2023
Merged
@carsonRadtke
Copy link
Contributor

$ git bisect determined the issue was introduced in 81f4e11.

It appears the "invalid non-printable character" error was identified, but not promptly emitted to the user. Then when the "expected an indented block" error comes around, we see we are about to overwrite an error and we abort.

@hugovk
Copy link
Member
hugovk commented Nov 25, 2023

Thanks for the report and bisecting.

cc @pablogsal

pablogsal added a commit to pablogsal/cpython that referenced this issue Nov 25, 2023
@pablogsal
pythongh-112388: Fix an error that was causing the parser to try to o…
4078c4d 
…verwrite tokenizer errors
@bedevere-app bedevere-app bot mentioned this issue Nov 25, 2023
Merged
pablogsal added a commit to pablogsal/cpython that referenced this issue Nov 25, 2023
< 8000 div class="AvatarStack-body" > @pablogsal
pythongh-112388: Fix an error that was causing the parser to try to o…
cef5ae9 
…verwrite tokenizer errors

Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
pablogsal added a commit that referenced this issue Nov 27, 2023
@pablogsal
gh-112388: Fix an error that was causing the parser to try to overwri…
2c8b191 
…te tokenizer errors (#112410)

Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Nov 27, 2023
@pablogsal @miss-islington
pythongh-112388: Fix an error that was causing the parser to try to o…
6e543d0 
…verwrite tokenizer errors (pythonGH-112410)

(cherry picked from commit 2c8b191)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
@bedevere-app bedevere-app bot mentioned this issue Nov 27, 2023
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Nov 27, 2023
@pablogsal @miss-islington
pythongh-112388: Fix an error that was causing the parser to try to o…
4d69501 
…verwrite tokenizer errors (pythonGH-112410)

(cherry picked from commit 2c8b191)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
@bedevere-app bedevere-app bot mentioned this issue Nov 27, 2023
Merged
@pablogsal
Copy link
Member

Thanks for the report!
8000

pablogsal added a commit that referenced this issue Nov 27, 2023
@miss-islington @pablogsal
[3.11] gh-112388: Fix an error that was causing the parser to try to …
43b081b 
…overwrite tokenizer errors (GH-112410) (#112467)

gh-112388: Fix an error that was causing the parser to try to overwrite tokenizer errors (GH-112410)
(cherry picked from commit 2c8b191)

Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
pablogsal added a commit that referenced this issue Nov 27, 2023
@miss-islington @pablogsal
[3.12] gh-112388: Fix an error that was causing the parser to try to …
698b4b7 
…overwrite tokenizer errors (GH-112410) (#112466)

gh-112388: Fix an error that was causing the parser to try to overwrite tokenizer errors (GH-112410)
(cherry picked from commit 2c8b191)

Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
@pablogsal pablogsal mentioned this issue Dec 31, 2023
Closed
aisk pushed a commit to aisk/cpython that referenced this issue Feb 11, 2024
@pablogsal @aisk
pythongh-112388: Fix an error that was causing the parser to try to o…
b998939 
…verwrite tokenizer errors (python#112410)

Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
Glyphack pushed a commit to Glyphack/cpython that referenced this issue Sep 2, 2024
@pablogsal @Glyphack
pythongh-112388: Fix an error that was causing the parser to try to o…
db9fb7e 
…verwrite tokenizer errors (python#112410)

Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-crash A hard crash of the interpreter, possibly with a core dump
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@hugovk @bradlarsen @carsonRadtke @pablogsal
0