8000 What’s New In Python 3.12: bad highlighting for Py_NewInterpreterFromConfig() example · Issue #111700 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

What’s New In Python 3.12: bad highlighting for Py_NewInterpreterFromConfig() example #111700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jwilk opened this issue Nov 3, 2023 · 5 comments · Fixed by #113609
Closed

What’s New In Python 3.12: bad highlighting for Py_NewInterpreterFromConfig() example #111700

jwilk opened this issue Nov 3, 2023 · 5 comments · Fixed by #113609
Labels
3.12 only security fixes 3.13 bugs and security fixes docs Documentation in the Doc dir easy type-bug An unexpected behavior, bug, or error

Comments

@jwilk
Copy link
jwilk commented Nov 3, 2023 •
edited by bedevere-app bot
Loading

In the "PEP 684: A Per-Interpreter GIL" section of "What’s New In Python 3.12", the C code snippet is highlighted as if it was Python.

Linked PRs
@hugovk
Copy link
Member
hugovk commented Nov 3, 2023

Thanks for the report!

This can be fixed by replacing the :: with : at the end of the paragraph preceding the paragraph, and adding .. code-block:: c between the paragraph and the snippet.

Would you like to create a PR and check if there are any other C snippets with Python formatting on the page?

@hugovk hugovk added type-bug An unexpected behavior, bug, or error docs Documentation in the Doc dir 3.12 only security fixes 3.13 bugs and security fixes labels Nov 3, 2023
@jwilk
Copy link
Author
jwilk commented Dec 29, 2023

Would you like to create a PR

No, sorry. CLA is a deal breaker for me.

@hugovk
Copy link
Member
hugovk commented Dec 29, 2023

Fair enough, let's add the easy label for someone else.

@hugovk hugovk added the easy label Dec 29, 2023
@parthsdoshi parthsdoshi mentioned this issue Jan 1, 2024
Merged
@parthsdoshi
Copy link
Contributor

Hopefully fixed above, lmk!

hugovk pushed a commit that referenced this issue Jan 1, 2024
@parthsdoshi
# gh-111700: Fix syntax highlighting for C code in the "What's New In…
9ce6c01 
… Python 3.12" documentation (#113609)

Fix PEP 684 syntax highlighting in what's new Python 3.12
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jan 1, 2024
@parthsdoshi @miss-islington
GH- pythongh-111700: Fix syntax highlighting for C code in the "What'…
4e12112 
…s New In Python 3.12" documentation (pythonGH-113609)

Fix PEP 684 syntax highlighting in what's new Python 3.12
(cherry picked from commit 9ce6c01)

Co-authored-by: Parth Doshi <doshi.parth9@gmail.com>
@bedevere-app bedevere-app bot mentioned this issue Jan 1, 2024
Merged
@hugovk
Copy link
Member
hugovk commented Jan 1, 2024

Thank you!

hugovk pushed a commit that referenced this issue Jan 1, 2024
@miss-islington @parthsdoshi
[3.12] GH- gh-111700: Fix syntax highlighting for C code in the "What…
c7a1431 
…'s New In Python 3.12" documentation (GH-113609) (#113610)

GH- gh-111700: Fix syntax highlighting for C code in the "What's New In Python 3.12" documentation (GH-113609)

Fix PEP 684 syntax highlighting in what's new Python 3.12
(cherry picked from commit 9ce6c01)

Co-authored-by: Parth Doshi <doshi.parth9@gmail.com>
kulikjak pushed a commit to kulikjak/cpython that referenced this issue Jan 22, 2024
@parthsdoshi @kulikjak
# pythongh-111700: Fix syntax highlighting for C code in the "What's …
ff307a9 
…New In Python 3.12" documentation (python#113609)

Fix PEP 684 syntax highlighting in what's new Python 3.12
aisk pushed a commit to aisk/cpython that referenced this issue Feb 11, 2024
@parthsdoshi @aisk
# pythongh-111700: Fix syntax highlighting for C code in the "What's …
535425e 
…New In Python 3.12" documentation (python#113609)

Fix PEP 684 syntax highlighting in what's new Python 3.12
Glyphack pushed a commit to Glyphack/cpython that referenced this issue Sep 2, 2024
@parthsdoshi @Glyphack
# pythongh-111700: Fix syntax highlighting for C code in the "What's …
336c057 
…New In Python 3.12" documentation (python#113609)

Fix PEP 684 syntax highlighting in what's new Python 3.12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.12 only security fixes 3.13 bugs and security fixes docs Documentation in the Doc dir easy type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
3 participants
@jwilk @hugovk @parthsdoshi
0