8000 --enable-pystats compile broken on main · Issue #111652 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

--enable-pystats compile broken on main #111652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mdboom opened this issue Nov 2, 2023 · 0 comments
Closed

--enable-pystats compile broken on main #111652

mdboom opened this issue Nov 2, 2023 · 0 comments
Assignees
@mdboom
Labels
build The build process and cross-build type-bug An unexpected behavior, bug, or error

Comments

@mdboom
Copy link
Contributor
mdboom commented Nov 2, 2023 •
edited by bedevere-app bot
Loading

Bug report

Bug description:

Compiling with --enable-pystats is currently broken.

gcc -c -fno-strict-overflow -Wsign-compare -DNDEBUG -g -O3 -Wall    -std=c11 -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wstrict-prototypes -Werror=implicit-function-declaration -fvisibility=hidden  -I./Include/internal -I./Include/internal/mimalloc  -I. -I./Include    -DPy_BUILD_CORE -o Python/ceval.o Python/ceval.c
In file included from ./Include/internal/pycore_interp.h:16,
                 from ./Include/internal/pycore_runtime.h:17,
                 from ./Include/internal/pycore_pystate.h:11,
                 from ./Include/internal/pycore_call.h:12,
                 from Python/ceval.c:7:
Python/ceval.c: In function ‘_PyEval_EvalFrameDefault’:
./Include/internal/pycore_code.h:291:26: error: implicit declaration of function ‘_Py_bit_length’; did you mean ‘Py_mp_length’? [-Werror=implicit-function-declaration]
  291 |             int bucket = _Py_bit_length(length >= 1 ? length - 1 : 0); \
      |                          ^~~~~~~~~~~~~~
Python/ceval.c:1049:5: note: in expansion of macro ‘OPT_HIST’
 1049 |     OPT_HIST(trace_uop_execution_counter, trace_run_length_hist);
      |     ^~~~~~~~

CPython versions tested on:

CPython main branch

Operating systems tested on:

Linux

Linked PRs
@mdboom mdboom added the type-bug An unexpected behavior, bug, or error label Nov 2, 2023
@mdboom mdboom changed the title --enable-pystats broken on main --enable-pystats compile broken on main Nov 2, 2023
@mdboom mdboom self-assigned this Nov 2, 2023
@AlexWaygood AlexWaygood added the build The build process and cross-build label Nov 2, 2023
mdboom added a commit to mdboom/cpython that referenced this issue Nov 2, 2023
@mdboom
pythongh-111652: Fix --enable-pystats build
12d868a 
7e135a moved code around such that _Py_bit_length was no longer
visible to OPT_HIST. This includes "pycore_bitutils.h" to address that.
@bedevere-app bedevere-app bot mentioned this issue Nov 2, 2023
Merged
mdboom added a commit to mdboom/cpython that referenced this issue Nov 2, 2023
@mdboom
pythongh-111652: Fix --enable-pystats build
3d16eaf 
7e135a moved code around such that _Py_bit_length was no longer
visible to OPT_HIST. This includes "pycore_bitutils.h" to address that.
mdboom added a commit to mdboom/cpython that referenced this issue Nov 3, 2023
@mdboom
pythongh-111652: Fix --enable-pystats build
8794817 
7e135a moved code around such that _Py_bit_length was no longer
visible to OPT_HIST. This includes "pycore_bitutils.h" to address that.
markshannon pushed a commit that referenced this issue Nov 3, 2023
@mdboom
gh-111652: Fix --enable-pystats build (GH-111653)
2bc01cc
aisk pushed a commit to aisk/cpython that referenced this issue Feb 11, 2024
@mdboom @aisk
pythongh-111652: Fix --enable-pystats build (pythonGH-111653)
6f2c98b
Glyphack pushed a commit to Glyphack/cpython that referenced this issue Sep 2, 2024
@mdboom @Glyphack
pythongh-111652: Fix --enable-pystats build (pythonGH-111653)
13da074
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mdboom mdboom

Labels
build The build process and cross-build type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mdboom @markshannon @AlexWaygood
0