8000 Forgot to add error check? · Issue #106916 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

Forgot to add error check? #106916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Eclips4 opened this issue Jul 20, 2023 · 3 comments
Closed

Forgot to add error check? #106916

Eclips4 opened this issue Jul 20, 2023 · 3 comments
Assignees
@methane @Eclips4
Labels
type-bug An unexpected behavior, bug, or error

Comments

@Eclips4
Copy link
Member
Eclips4 commented Jul 20, 2023 •
edited by bedevere-bot
Loading

#106411 adds the _PyCompile_CleanDoc function.
there's a call to PyMem_Malloc, but we don't check if it returns NULL value:

cpython/Python/compile.c

Lines 8055 to 8063 in 009e8f0

char *buff = PyMem_Malloc(doc_size);
char *w = buff;
while (p < pend) {
int ch = *w++ = *p++;
if (ch == '\n') {
break;
}
}

Is there a need to check for a NULL value?
If so, I can send a PR.

Linked PRs
@Eclips4 Eclips4 added the type-bug An unexpected behavior, bug, or error label Jul 20, 2023
@Eclips4
Copy link
Member Author
Eclips4 commented Jul 20, 2023

cc @methane

@methane
Copy link
Member
methane commented Jul 20, 2023

Yes, I forgot. Thank you.
Would you create a pull request, or may I?

@Eclips4
Copy link
Member Author
Eclips4 commented Jul 20, 2023

I'll soon send a pull request =)

@bedevere-bot bedevere-bot mentioned this issue Jul 20, 2023
Merged
Eclips4 added a commit to Eclips4/cpython that referenced this issue Jul 20, 2023
@Eclips4
pythongh-106916: Add missing error check
618f708
methane pushed a commit that referenced this issue Jul 21, 2023
@Eclips4 @serhiy-storchaka
gh-106916: Add missing error check _PyCompile_CleanDoc (#106921)
85ed1d2 
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@methane methane closed this as completed Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@methane methane

@Eclips4 Eclips4

Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@methane @Eclips4
0