8000 Miscellaneous fixes in Python/suggestions.c · Issue #106030 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

Miscellaneous fixes in Python/suggestions.c #106030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
serhiy-storchaka opened this issue Jun 23, 2023 · 0 comments
Closed

Miscellaneous fixes in Python/suggestions.c #106030

serhiy-storchaka opened this issue Jun 23, 2023 · 0 comments
Labels
type-bug An unexpected behavior, bug, or error

Comments

@serhiy-storchaka
Copy link
Member
serhiy-storchaka commented Jun 23, 2023 •
edited by bedevere-bot
Loading
  • PyDict_GetItem() and PyObject_HasAttr() suppress arbitrary errors and
    should not be used.
  • PyUnicode_CompareWithASCIIString() only works if the second argument
    is ASCII string.
  • Refleak in get_suggestions_for_name_error.
  • Use of borrowed pointer after possible freeing (self).
  • Add some missing error checks.

Linked PRs
@serhiy-storchaka serhiy-storchaka added the type-bug An unexpected behavior, bug, or error label Jun 23, 2023
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this issue Jun 23, 2023
@serhiy-storchaka
pythongh-106030: Miscaleous fixes in Python/suggestions.c
3d6655d 
* PyDict_GetItem() and PyObject_HasAttr() suppress arbitrary errors and
  should not be used.
* PyUnicode_CompareWithASCIIString() only works if the second argument
  is ASCII string.
* Refleak in get_suggestions_for_name_error.
* Use of borrowed pointer after possible freeing (self).
* Add some missing error checks.
@bedevere-bot bedevere-bot mentioned this issue Jun 23, 2023
Merged
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this issue Jun 23, 2023
@serhiy-storchaka
pythongh-106030: Miscaleous fixes in Python/suggestions.c
c82f8b8 
* PyDict_GetItem() and PyObject_HasAttr() suppress arbitrary errors and
  should not be used.
* PyUnicode_CompareWithASCIIString() only works if the second argument
  is ASCII string.
* Refleak in get_suggestions_for_name_error.
* Use of borrowed pointer after possible freeing (self).
* Add some missing error checks.
@AlexWaygood AlexWaygood changed the title Miscaleous fixes in Python/suggestions.c Miscellaneous fixes in Python/suggestions.c Jun 23, 2023
serhiy-storchaka added a commit that referenced this issue Jun 23, 2023
@serhiy-storchaka
gh-106030: Miscellaneous fixes in Python/suggestions.c (GH-106031)
c8c162e 
* PyDict_GetItem() and PyObject_HasAttr() suppress arbitrary errors and
  should not be used.
* PyUnicode_CompareWithASCIIString() only works if the second argument
  is ASCII string.
* Refleak in get_suggestions_for_name_error.
* Use of borrowed pointer after possible freeing (self).
* Add some missing error checks.
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jun 23, 2023
@serhiy-storchaka @miss-islington
pythongh-106030: Miscellaneous fixes in Python/suggestions.c (pythonG…
1e9fb9d 
…H-106031)

* PyDict_GetItem() and PyObject_HasAttr() suppress arbitrary errors and
  should not be used.
* PyUnicode_CompareWithASCIIString() only works if the second argument
  is ASCII string.
* Refleak in get_suggestions_for_name_error.
* Use of borrowed pointer after possible freeing (self).
* Add some missing error checks.
(cherry picked from commit c8c162e)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot bedevere-bot mentioned this issue Jun 23, 2023
Merged
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this issue Jun 23, 2023
@serhiy-storchaka
[3.11] pythongh-106030: Miscellaneous fixes in Python/suggestions.c (p…
de2160e 
…ythonGH-106031)

* PyDict_GetItem() and PyObject_HasAttr() suppress arbitrary errors and
  should not be used.
* PyUnicode_CompareWithASCIIString() only works if the second argument
  is ASCII string.
* Refleak in get_suggestions_for_name_error.
* Use of borrowed pointer after possible freeing (self).
* Add some missing error checks..
(cherry picked from commit c8c162e)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this issue Jun 23, 2023
@serhiy-storchaka
[3.11] pythongh-106030: Miscellaneous fixes in Python/suggestions.c (p…
f8ca034 
…ythonGH-106031)

* PyUnicode_CompareWithASCIIString() only works if the second argument
  is ASCII string.
* Refleak in get_suggestions_for_name_error.
* Add some missing error checks..
(cherry picked from commit c8c162e)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot bedevere-bot mentioned this issue Jun 23, 2023
Merged
serhiy-storchaka added a commit that referenced this issue Jun 23, 2023
@serhiy-storchaka
[3.11] gh-106030: Miscellaneous fixes in Python/suggestions.c (GH-106… (
26d87fd 
GH-106039)

* PyUnicode_CompareWithASCIIString() only works if the second argument
  is ASCII string.
* Refleak in get_suggestions_for_name_error.
* Add some missing error checks.

(cherry picked from commit c8c162e)
hauntsaninja pushed a commit that referenced this issue Jun 27, 2023
@miss-islington @serhiy-storchaka
[3.12] gh-106030: Miscellaneous fixes in Python/suggestions.c (GH-106031
1bb2bf7 
) (#106036)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@serhiy-storchaka
0