8000 Improve error message for unterminated strings with escapes · Issue #100445 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

Improve error message for unterminated strings with escapes #100445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hauntsaninja opened this issue Dec 23, 2022 · 0 comments
Closed

Improve error message for unterminated strings with escapes #100445

hauntsaninja opened this issue Dec 23, 2022 · 0 comments
Labels
type-feature A feature request or enhancement

Comments

@hauntsaninja
Copy link
Contributor
hauntsaninja commented Dec 23, 2022 •
edited
Loading

Inspired by #55688 and #94768.

Currently, this code raises the following error:

>>> "asdf\"
  File "<stdin>", line 1
    "asdf\"
    ^
SyntaxError: unterminated string literal (detected at line 1)

Maybe there's room to make this error message more helpful, to make the source of the error more obvious for users unfamiliar with escapes. Could the following be better?

>>> "asdf\"
  File "<stdin>", line 1
    "asdf\"
    ^
SyntaxError: unterminated string literal (detected at line 1); perhaps you escaped the end quote?

(The raw string situation in the linked issues that inspired this is a little extra tricky, since the workaround is still not clear. But hopefully the message still makes it clearer to users what is going on)

Linked PRs
@hauntsaninja hauntsaninja added the type-feature A feature request or enhancement label Dec 23, 2022
@hauntsaninja hauntsaninja changed the title Improve error message for unterminated raw strings Improve error message for unterminated strings with escapes Dec 23, 2022
hauntsaninja added a commit to hauntsaninja/cpython that referenced this issue Dec 23, 2022
@hauntsaninja
pythongh-100445: Improve error message for unterminated strings with …
bf712e8 
…escapes
@bedevere-bot bedevere-bot mentioned this issue Dec 23, 2022
Merged
AlexWaygood added a commit to hauntsaninja/cpython that referenced this issue Apr 24, 2023
@AlexWaygood
Merge branch 'main' into pythongh-100445
c848f39
hauntsaninja added a commit to hauntsaninja/cpython that referenced this issue Sep 16, 2023
@hauntsaninja
pythongh-100445: Improve error message for unterminated strings with …
a844eaf 
…escapes
hauntsaninja added a commit to hauntsaninja/cpython that referenced this issue Sep 16, 2023
@hauntsaninja
Merge branch 'main' into pythongh-100445
78ca307
hauntsaninja added a commit to hauntsaninja/cpython that referenced this issue Sep 16, 2023
@hauntsaninja
pythongh-100445: Improve error message for unterminated strings with …
4fb56c9 
…escapes
hauntsaninja added a commit to hauntsaninja/cpython that referenced this issue Oct 18, 2023
@hauntsaninja
Merge remote-tracking branch 'upstream/main' into pythongh-100445
434e04a
pablogsal pushed a commit that referenced this issue Oct 18, 2023
@hauntsaninja
gh-100445: Improve error message for unterminated strings with escapes (
3156d19 
#100446)
aisk pushed a commit to aisk/cpython that referenced this issue Feb 11, 2024
@hauntsaninja @aisk
pythongh-100445: Improve error message for unterminated strings with …
70eeef6 
…escapes (python#100446)
Glyphack pushed a commit to Glyphack/cpython that referenced this issue Sep 2, 2024
@hauntsaninja @Glyphack
pythongh-100445: Improve error message for unterminated strings with …
7afe9d7 
…escapes (python#100446)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hauntsaninja
0