8000 Support GitHub Issues by Mariatta · Pull Request #431 · python/core-workflow · GitHub
[go: up one dir, main page]
Skip to content

Support GitHub Issues #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 7, 2022
Merged

Support GitHub Issues #431

merged 6 commits into from
Apr 7, 2022

Conversation

Mariatta
Copy link
Member

Use issue instead of bpo in the metadata.
Use gh-<number> in the misc/news filename

Bump the version to 1.1.0

Closes #428

@Mariatta
Support GitHub Issues
e6d3c25 
Use `issue` instead of `bpo` in the metadata.
Use `gh-<number>` in the misc/news filename

Bump the version to 1.1.0

Closes #428
@Mariatta Mariatta requested a review from larryhastings March 15, 2022 17:24
@Mariatta Mariatta mentioned this pull request Mar 15, 2022
Closed
arhadthedev
arhadthedev reviewed Mar 15, 2022
View reviewed changes
ezio-melotti
ezio-melotti requested changes Mar 15, 2022
View reviewed changes
@Mariatta @arhadthedev
Clarify that b.p.o means bugs.python.org on the changelog
91e5885 
Co-authored-by: Oleg Iarygin <dralife@yandex.ru>
@ezio-melotti
Copy link
Member

FYI, we are planning to migrate the issues this weekend, and as soon as the migration is complete, we should merge this PR.

@ezio-melotti ezio-melotti mentioned this pull request Mar 24, 2022
Open
58 tasks
@Mariatta
Support bpo as well because the blurb merge command still
c39afa5 
need to be able to read the existing `bpo-` news files.

If the metadata contains `bpo-`, then append `bpo-` to the filename.
Else, append `gh-issue`.
@Mariatta
Copy link
Member Author

In case you need to publish the package to PyPI this weekend, I think only @brettcannon or @larryhastings can do it.

See https://pypi.org/project/blurb/

@Mariatta Mariatta requested a review from ezio-melotti March 24, 2022 04:20
ezio-melotti
ezio-melotti reviewed Mar 25, 2022
View reviewed changes
Copy link
Member
@ezio-melotti ezio-melotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My comments have been addressed. I'm not familiar enough with the rest of the code to tell whether the changes are correct, but if you tested them and they work I'll assume they are ok :)

@arhadthedev
Copy link
Member

There is a discrepancy in the prefix:

  • gh-issue- in the tests, changelog and some parts of the script
  • gh- in other parts of the script and readme

@Mariatta
Copy link
Member Author

@arhadthedev I've updated the readme. If you found more references to gh- please let me know. I believe I've gone through them all, but it's possible that I still miss some of them.

Thanks.

@ezio-melotti Yes I tested locally doing blurb add and blurb merge commands on the current CPython repo. I'm pretty confident about the changes.

ezio-melotti
ezio-melotti approved these changes Mar 28, 2022
View reviewed changes
Copy link
Member
@ezio-melotti ezio-melotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since now both are supported, what happens if someone adds both .. bpo: and .. gh-issue:?

The rest LGTM.

@Mariatta
Copy link
Member Author

If they add both .. bpo: and .. gh-issue: then the bpo number gets used. However, in order for this to happen, they need to manually add a new .. bpo: line to the template provided by blurb. I think this won't happen as often.

I can make the change so that only gh-issue is taken in this case.

@ezio-melotti ezio-melotti merged commit 6008a9b into master Apr 7, 2022
@JelleZijlstra JelleZijlstra deleted the use-gh-issues branch April 7, 2022 20:24
@ezio-melotti
Copy link
Member

@brettcannon, can you publish this on PyPI?
Since the new version supports both bpo and GH ids, it can be published even before the migration and people can keep using bpo ids. The migration should be completed this Sunday, so it would be good to have blurb updated on PyPI by then.

@Mariatta
Copy link
Member Author
Mariatta commented Apr 7, 2022

@brettcannon I also can do the publishing going forward if you want. I just need to be added to the PyPI project for blurb. Thanks.

JelleZijlstra added a commit to python/bedevere that referenced this pull request Apr 10, 2022
@JelleZijlstra
Fix gh-issue- prefix
bd11ac5 
Blurb generates gh-issue- but Bedevere only accepted gh-. This was discussed here: python/core-workflow#431 (comment)
@JelleZijlstra JelleZijlstra mentioned this pull request Apr 10, 2022
Merged
@sweeneyde sweeneyde mentioned this pull request Apr 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arhadthedev arhadthedev arhadthedev left review comments

@ezio-melotti ezio-melotti ezio-melotti approved these changes

@larryhastings larryhastings Awaiting requested review from larryhastings

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update blurb to use GitHub IDs
4 participants
@Mariatta @ezio-melotti @arhadthedev @the-knights-who-say-ni
0