8000 Mark generated files with custom `generated` git diff driver · Issue #425 · python/core-workflow · GitHub
[go: up one dir, main page]
Skip to content
8000

Mark generated files with custom generated git diff driver #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
erlend-aasland opened this issue Jan 20, 2022 · 4 comments · Fixed by python/cpython#30745
Closed

Mark generated files with custom generated git diff driver #425

erlend-aasland opened this issue Jan 20, 2022 · 4 comments · Fixed by python/cpython#30745

Comments

@erlend-aasland
Copy link

In .gitattributes, add diff=generated to generated files so one conveniently can configure git diff to ignore them, for example by marking them as "binary files" (git config diff.generated.binary true). This should not impact how GitHub renders such diffs.

Suggestion stolen from @zware on Discord 😎
@erlend-aasland
Copy link
Author

See also:

@isidentical
Copy link
Member

If someone takes over, here is a prepared list from a year back. Probably it got changed a lot, but might be useful base python/cpython#20314

@erlend-aasland erlend-aasland mentioned this issue Jan 21, 2022
Merged
@erlend-aasland
Copy link
Author

See also https://bugs.python.org/issue40729

miss-islington pushed a commit to python/cpython that referenced this issue Jan 21, 2022
Update generated files list and add diff=generated attribute (GH-30745
f1e559b 
)

As a side effect, the list of generated files is relocated after the language aware diff settings.

Closes python/core-workflow#425

Automerge-Triggered-By: GH:zware
@zware
Copy link
Member
zware commented Jan 21, 2022

Done in python/cpython#30745.

@zware zware closed this as completed Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? < 4AF2 a rel="nofollow" class="Link--inTextBlock" data-hydro-click="{"event_type":"authentication.click","payload":{"location_in_page":"signed out comment","repository_id":76080865,"auth_type":"LOG_IN","originating_url":"https://github.com/python/core-workflow/issues/425","user_id":null}}" data-hydro-click-hmac="216e7603876eb359ece724d9e60d0a30b2bb74d2947850d2e5ef7006d546f972" data-test-selector="comments-sign-in-link" href="/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcore-workflow%2Fissues%2F425">Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update generated files list and add diff=generated attribute erlend-aasland/cpython
3 participants
@zware @erlend-aasland @isidentical
0