8000 Fix script reference, found in a submodule of the same name as the package. by jaraco · Pull Request #28 · python/cherry-picker · GitHub
[go: up one dir, main page]
Skip to content

Fix script reference, found in a submodule of the same name as the package. #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 3, 2021
Merged

Fix script reference, found in a submodule of the same name as the package. #28

merged 3 commits into from
Jun 3, 2021

Conversation

jaraco
Copy link
Member
@jaraco jaraco commented Jun 3, 2021

Fixes #26.

@gpshead
Copy link
Member
gpshead commented Jun 3, 2021

Bonus points if you can add something to the CI config that runs cherry_picker --help as a regression test for the CLI working.

@jaraco
Copy link
Member Author
jaraco commented Jun 3, 2021

Done. You can see in the failed run the reported error message appears. When merged with the fix, the error goes away.

@jaraco jaraco merged commit f02b68c into main Jun 3, 2021
@jaraco jaraco deleted the bugfix/26-fix-script-ref branch June 3, 2021 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@isidentical isidentical isidentical approved these changes

Assignees

No one assigned

Labels

CLA signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

cherry_picker executable script is broken

4 participants

@jaraco @gpshead @isidentical @the-knights-who-say-ni
0