8000 Update minimum Python version to 3.9 in the configuration by OlenaYefymenko · Pull Request #137 · python/cherry-picker · GitHub
[go: up one dir, main page]
Skip to content

Update minimum Python version to 3.9 in the configuration #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 11, 2024
Merged

Update minimum Python version to 3.9 in the configuration #137

merged 2 commits into from
Oct 11, 2024

Conversation

OlenaYefymenko
Copy link
Contributor

🍒Update minimum Python version to 3.9 in the configuration

Resolves #136

@ghost
Copy link
ghost commented Oct 11, 2024 •
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@hugovk hugovk added the hacktoberfest-accepted Accepted for hacktoberfest label Oct 11, 2024
@hugovk
Copy link
Member
hugovk commented Oct 11, 2024

Thanks for the PR!

There's some linting to fix.

Please could you run:

python -m pip install pre-commit
pre-commit run --all-files

Or if you use uv, something like this:

uvx pre-commit run --all-files

And commit the changed file?

@OlenaYefymenko
Copy link
Contributor Author

Thanks for the PR!

There's some linting to fix.

Please could you run:

python -m pip install pre-commit
pre-commit run --all-files

Or if you use uv, something like this:

uvx pre-commit run --all-files

And commit the changed file?

Thank you for the feedback!
Yes, I can run pre-commit tool
Please advise, should I make changes for test_cherry_picker.py within this PR, or is it better to open a new PR?
I worry about atomic, this is formatted changes and not connected with the Python version.

@zware
Copy link
Member
zware commented Oct 11, 2024

IIUC the formatting changes are a direct result of no longer supporting 3.8, so I think it's fine to include them here.

Separately, it looks like the pre-commit configuration could stand an update (which should be a separate PR :))

@OlenaYefymenko
Copy link
Contributor Author

IIUC the formatting changes are a direct result of no longer supporting 3.8, so I think it's fine to include them here.

Separately, it looks like the pre-commit configuration could stand an update (which should be a separate PR :))

Thank you for pointing, I added this change.

hugovk
hugovk approved these changes Oct 11, 2024
View reviewed changes
Copy link
Member
@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! 🎃🍒

@hugovk hugovk merged commit 7fdaa08 into python:main Oct 11, 2024
22 checks passed
@webknjaz
Copy link
Contributor

@hugovk perhaps, somebody has to enable the pre-commit.ci app for this repo, eh?

@hugovk
Copy link
Member
hugovk commented Oct 12, 2024

Good idea, I sent a request via https://pre-commit.ci/ to enable this repo. @JacobCoffee, please can you accept it?

@JacobCoffee
Copy link
Member

@hugovk done

@hugovk
Copy link
Member
hugovk commented Oct 16, 2024

Thanks!

@hugovk hugovk mentioned this pull request Nov 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes

@zware zware zware approved these changes

Assignees

No one assigned

Labels

hacktoberfest-accepted Accepted for hacktoberfest

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[TODO] Complete dropping support for Python 3.8

5 participants

@OlenaYefymenko @hugovk @zware @webknjaz @JacobCoffee
0