8000 Resolve usernames when the remote ends with a trailing slash by AA-Turner · Pull Request #110 · python/cherry-picker · GitHub
[go: up one dir, main page]
Skip to content

Resolve usernames when the remote ends with a trailing slash #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 21, 2024
Merged

Resolve usernames when the remote ends with a trailing slash #110

merged 4 commits into from
Jan 21, 2024

Conversation

AA-Turner
Copy link
Member
@AA-Turner AA-Turner commented Jan 20, 2024 •
edited
Loading

Closes #109

AA-Turner
AA-Turner commented Jan 20, 2024
View reviewed changes
@AA-Turner AA-Turner linked an issue Jan 20, 2024 that may be closed by this pull request
Username detection fails with a trailing slash #109
Closed
ezio-melotti
ezio-melotti reviewed Jan 20, 2024
View reviewed changes
Copy link
Member
@ezio-melotti ezio-melotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix LGTM, but I would add a test here:

cherry-picker/cherry_picker/test_cherry_picker.py

Lines 341 to 358 in c7a504f

@pytest.mark.parametrize(
"url",
[
b"git@github.com:mock_user/cpython.git",
b"git@github.com:mock_user/cpython",
b"ssh://git@github.com/mock_user/cpython.git",
b"ssh://git@github.com/mock_user/cpython",
b"https://github.com/mock_user/cpython.git",
b"https://github.com/mock_user/cpython",
],
)
def test_username(url, config):
branches = ["3.6"]
cp = CherryPicker(
"origin", "22a594a0047d7706537ff2ac676cdc0f1dcb329c", branches, config=config
)
with mock.patch("subprocess.check_output", return_value=url):
assert cp.username == "mock_user"

@AA-Turner AA-Turner merged commit d7c3264 into main Jan 21, 2024
@AA-Turner AA-Turner deleted the username-resolution branch January 21, 2024 08:44
@AA-Turner AA-Turner mentioned this pull request Sep 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk left review comments

@ezio-melotti ezio-melotti ezio-melotti left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Username detection fails with a trailing slash

3 participants

@AA-Turner @hugovk @ezio-melotti
0