8000 Issue #419: Only add Tier-1 and Tier-2 builders to Release Status by vstinner · Pull Request #422 · python/buildmaster-config · GitHub
[go: up one dir, main page]
Skip to content

Issue #419: Only add Tier-1 and Tier-2 builders to Release Status #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 11, 2023
Merged

Issue #419: Only add Tier-1 and Tier-2 builders to Release Status #422

merged 2 commits into from
Oct 11, 2023

Conversation

vstinner
Copy link
Member

No description provided.

@vstinner vstinner mentioned this pull request Oct 11, 2023
Closed
@vstinner
Copy link
Member Author

cc @ambv @pablogsal @zware

ambv
ambv reviewed Oct 11, 2023
View reviewed changes
master/master.cfg
@@ -252,6 +253,9 @@ for branch_num, (git_url, branchname, git_branch) in enumerate(git_branches):
# disable GitHub notifications for unstable builders
if stability == STABLE:
github_status_builders.append(buildername)
# Only Tier-1 and Tier-2 builders can block a release
if tier in (TIER_1, TIER_2):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

builtins.NameError: name 'TIER_1' is not defined

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed ;-)

@ambv ambv merged commit c51d56f into python:main Oct 11, 2023
@vstinner vstinner deleted the release_status_tier branch October 11, 2023 13:40
@vstinner
Copy link
Member Author

Thanks for the review @ambv.

@itamaro
Copy link
Contributor
itamaro commented Oct 11, 2023

Does this change affect the release manager workflow? Are all RMs aware?

@vstinner
Copy link
Member Author

cc @pablogsal @Yhg1s @ambv: I fixed https://buildbot.python.org/all/#/release_status page to only list buildbot builders of Tier-1 and Tier-2. Builders of Tier-3 or with no Tier must not block a release and so are no longer listed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ambv ambv ambv left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vstinner @itamaro @ambv
0