8000 Test `__main__.py` by hugovk · Pull Request #409 · python/blurb_it · GitHub
[go: up one dir, main page]
Skip to content

Test __main__.py #409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 2, 2024
Merged

Test __main__.py #409

merged 2 commits into from
Nov 2, 2024

Conversation

hugovk
Copy link
Member
@hugovk hugovk commented Nov 1, 2024

Helps #14.

Bumps blurb_it/__main__.py coverage from 0% to 39%, overall coverage from 43% to 70%.

@hugovk hugovk changed the title Test __main__ Test __main__.py Nov 1, 2024
AA-Turner
AA-Turner approved these changes Nov 1, 2024
View reviewed changes
Copy link
Member
@AA-Turner AA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we could use TYPE_CHECKING? But looks good.

A

ezio-melotti
ezio-melotti reviewed Nov 2, 2024
View reviewed changes
@hugovk @ezio-melotti
Use PathLib instead of os
fa6329a 
Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
@hugovk hugovk merged commit 765b2d3 into python:main Nov 2, 2024
8 checks passed
@hugovk hugovk deleted the test-main branch November 2, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AA-Turner AA-Turner AA-Turner approved these changes

@ezio-melotti ezio-melotti ezio-melotti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hugovk @AA-Turner @ezio-melotti
0