Set exit code if bedevere errors out.

python · Mariatta · Jun 12, 2023 · Jun 12, 2023 · Jun 12, 2023 · Jun 12, 2023
commit 784a19cfa7c0dc883e74bea7927d8c12dbfe2d47
diff --git a/bedevere/__main__.py b/bedevere/__main__.py
@@ -43,10 +43,10 @@ async def main(event_payload):
             print('GH requests remaining:', gh.rate_limit.remaining)
         except AttributeError:
             pass
-        return True
+
     except Exception as exc:
         traceback.print_exc(file=sys.stderr)
-        return False
+        sys.exit(1)
 
 if __name__ == "__main__":  # pragma: no cover
     if os.environ.get("GITHUB_EVENT_PATH"):

diff --git a/tests/test___main__.py b/tests/test___main__.py
@@ -11,14 +11,15 @@ async def test_success(tmp_webhook, tmp_event_name, tmp_job_id, monkeypatch):
     # Sending a payload that shouldn't trigger any networking, but no errors
     # either.
     event_payload = {"action": "created"}
-    response = await main.main(event_payload)
-    assert response
+    await main.main(event_payload)
+
 
 async def test_failure(tmp_webhook):
     from bedevere import __main__ as main
-    """Even in the face of an exception, actions will not crash."""
+    """Actions will have exit code in case of errors."""
 
     # Missing GitHub environment variables
     event_payload = {}
-    response = await main.main(event_payload)
-    assert not response
+    with pytest.raises(SystemExit) as exc:
+        await main.main(event_payload)
+    assert exc.value.code == 1