10000 Comment about a backport even if the original PR doesn't have a label by DanielNoord · Pull Request #489 · python/bedevere · GitHub
[go: up one dir, main page]

Skip to content

Comment about a backport even if the original PR doesn't have a label #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2022
Merged

Comment about a backport even if the original PR doesn't have a label #489

merged 1 commit into from
Oct 10, 2022

Conversation

DanielNoord
Copy link
Contributor

Closes #440.

The if ... return makes it so we never comment if there original PR doesn't have a back port label.

@codecov
Copy link
codecov bot commented Jul 12, 2022

Codecov Report

Merging #489 (1924a0a) into main (83a2d22) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #489   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines         1815      1831   +16     
  Branches       220       222    +2     
=========================================
+ Hits          1815      1831   +16     
Flag Coverage Δ
Python_3.10 100.00% <100.00%> (ø)
Python_3.11-dev 100.00% <100.00%> (ø)
Python_3.8 100.00% <100.00%> (ø)
Python_3.9 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
bedevere/backport.py 100.00% <100.00%> (ø)
tests/test_backport.py 100.00% <100.00%> (ø)

@DanielNoord
Copy link
Contributor Author

@ezio-melotti Gentle ping as you have been helpful in reviewing some of my other PRs and this is fixing an issue that you originally opened yourself. Feel free to ignore of course!

@ezio-melotti ezio-melotti merged commit 01fc118 into python:main Oct 10, 2022
@DanielNoord DanielNoord deleted the backport-comment branch October 10, 2022 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conflict while backporting issue-less PRs
2 participants
0