8000 leave codeblocks untouched while hyperlinking by danishprakash · Pull Request #144 · python/bedevere · GitHub
[go: up one dir, main page]
Skip to content

leave codeblocks untouched while hyperlinking #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

leave codeblocks untouched while hyperlinking #144

wants to merge 2 commits into from

Conversation

danishprakash
Copy link

Almost always, we would want the text inside a code block to be the way it is/untouched. This has, previously, lead to a few problems in discussions and otherwise. See the discussion over at #136.

Closes #136

@codecov
Copy link
codecov bot commented Dec 8, 2018 •
edited
Loading

Codecov Report

Merging #144 into master will decrease coverage by 0.06%.
The diff coverage is 96.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #144      +/-   ##
==========================================
- Coverage     100%   99.93%   -0.07%     
==========================================
  Files          20       20              
  Lines        1530     1560      +30     
  Branches       86       87       +1     
==========================================
+ Hits         1530     1559      +29     
- Misses          0        1       +1
Impacted Files Coverage Δ
tests/test_bpo.py 100% <100%> (ø) ⬆️
bedevere/bpo.py 99.06% <91.66%> (-0.94%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f83f6b6...886ffef. Read the comment docs.

@brettcannon
Copy link
Member

@danishprakash please add tests to get code coverage back up to 100%.

@danishprakash danishprakash force-pushed the fix-issue-136 branch 2 times, most recently from c70d674 to 6223785 Compare January 15, 2019 04:23
< 8000 div class="d-flex flex-auto">
@danishprakash
test bpo in codeblocks
886ffef
@nightlark
Copy link
nightlark commented Aug 18, 2021 •
edited
Loading

Is this PR one that can be closed? The GitHub autolink feature enabled as part of python/core-workflow#361 seems to handle the case of leaving codeblocks (and things enclosed by backticks) untouched (and #196 removes this feature from bedevere).

@brettcannon
Copy link
Member

Yes, we can close it as out-of-date (sorry to @danishprakash if they did fix things as requested and people forgot to notify folks to review again).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Automatically hyperlinking of bpo- text sometimes causes confusion
4 participants
@danishprakash @brettcannon @nightlark @the-knights-who-say-ni
0