10BC0 chore: It's <current year>, 120 is fine by BeyondEvil · Pull Request #625 · pytest-dev/pytest-html · GitHub
[go: up one dir, main page]
Skip to content

chore: It's <current year>, 120 is fine #625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 5, 2023
Merged

chore: It's <current year>, 120 is fine #625

merged 1 commit into from
Apr 5, 2023

Conversation

BeyondEvil
Copy link
Contributor

No description provided.

@BeyondEvil BeyondEvil merged commit b6763d7 into pytest-dev:master Apr 5, 2023
@BeyondEvil BeyondEvil deleted the beyondevil/allow-longer-codelines branch April 5, 2023 19:45
RonnyPfannschmidt
RonnyPfannschmidt reviewed Apr 5, 2023
View reviewed changes
Copy link
Member
@RonnyPfannschmidt RonnyPfannschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

black is very clean on why 88 ^^

@BeyondEvil
Copy link
Contributor Author

I'll go with the Bugbear version, I don't want to be bothered if my line of text is 89, because then I have to introduce awkward breaks in the text.

For code, 88 is fine.

< 65B3 /form>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RonnyPfannschmidt RonnyPfannschmidt RonnyPfannschmidt left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BeyondEvil @RonnyPfannschmidt
0