8000 Make the maximum asset filename length configurable. by D3X · Pull Request #313 · pytest-dev/pytest-html · GitHub
[go: up one dir, main page]
Skip to content

Make the maximum asset filename length configurable. #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 27, 2020
Merged

Make the maximum asset filename length configurable. #313

merged 2 commits into from
Jul 27, 2020

Conversation

D3X
Copy link
Contributor
@D3X D3X commented Jul 7, 2020 •
edited
Loading

Some filesystems do not support filenames that are 255 characters long. Notably, aufs used by CircleCI only supports filenames up to 242 characters.
By making this a configurable option, we allow users to set their desired length limit.

@BeyondEvil
Copy link
Contributor

Awesome!

Should this be an ini-option instead of a command line option? 🤔

@D3X
Copy link
Contributor Author
D3X commented Jul 14, 2020

@BeyondEvil I have changed it to be an ini option and force-pushed. It's failing linting, because flake8 has a different rule than black regarding whitespace before colons. Probably something to be fixed in a separate PR.

@BeyondEvil
Copy link
Contributor

@BeyondEvil I have changed it to be an ini option and force-pushed. It's failing linting, because flake8 has a different rule than black regarding whitespace before colons. Probably something to be fixed in a separate PR.

Interesting, I'll pull your PR and check it out.

@BeyondEvil
Copy link
Contributor

@D3X

Please just add ignore = E203 under the [flake8] section in tox.ini

@BeyondEvil
Copy link
Contributor

Sorry @D3X I should've been more clear, apart from adding ignore = E203 you also have to put that space before colon. That's why linting failed now.

As a side note, are you using pre-commit with this project? It would've caught the above before committing. Instructions here

@D3X
Copy link
Contributor Author
D3X commented Jul 27, 2020

@BeyondEvil sorry it took so long, I was quite busy the last couple of weeks. The build's green now, so hopefully we can get this merged and released soon-ish ;)

BeyondEvil
BeyondEvil approved these changes Jul 27, 2020
View reviewed changes
Copy link
Contributor
@BeyondEvil BeyondEvil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@BeyondEvil BeyondEvil merged commit 4556076 into pytest-dev:master Jul 27, 2020
@D3X D3X deleted the configurable-max-filename-length branch July 27, 2020 12:16
@ssbarnea ssbarnea added the feature This issue/PR relates to a feature request. label Aug 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BeyondEvil BeyondEvil BeyondEvil approved these changes

Assignees

No one assigned

Labels

feature This issue/PR relates to a feature request.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@D3X @BeyondEvil @ssbarnea
0