8000 Fix collapsable bug by BeyondEvil · Pull Request #268 · pytest-dev/pytest-html · GitHub
[go: up one dir, main page]

Skip to content

Conversation

BeyondEvil
Copy link
Contributor
@BeyondEvil BeyondEvil commented Feb 20, 2020

Fixes #239 (again)

Had placed the collapsed class in the wrong tag.

Which in the end was a good thing since I discovered that JS needed an update as well to display the correct CSS (show/hide text).

@BeyondEvil
Copy link
Contributor Author

ping reviewers @nicoddemus @rochacbruno @davehunt

@nicoddemus
Copy link
Member

Thanks for the ping @BeyondEvil, but I'm not sure I can review this PR right now. Others are welmcome to!

Copy link
Collaborator
@davehunt davehunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@BeyondEvil BeyondEvil merged commit 593bbda into pytest-dev:master Feb 25, 2020
@BeyondEvil BeyondEvil deleted the fix-collapsable branch February 25, 2020 11:41
@BeyondEvil
Copy link
Contributor Author

Released in v2.1.0

@ssbarnea ssbarnea added the bug This issue/PR relates to a bug. label Aug 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug This issue/PR relates to a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Opening report is slow when it contains long logs

4 participants

0