E547 Fix assets file naming to work across both *nix and windows by BeyondEvil · Pull Request #223 · pytest-dev/pytest-html · GitHub
[go: up one dir, main page]
Skip to content

Fix assets file naming to work across both *nix and windows #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 6, 2019
Merged

Fix assets file naming to work across both *nix and windows #223

merged 4 commits into from
Aug 6, 2019

Conversation

BeyondEvil
Copy link
Contributor

Instead of a combination of human readable filename and hash, let's try a filename with cross-OS friendly formatting.

Fixes #214
Fixes #213

This was referenced Aug 4, 2019
Closed
Closed
BeyondEvil
BeyondEvil commented Aug 4, 2019
View reviewed changes
davehunt
davehunt previously approved these changes Aug 5, 2019
View reviewed changes
@BeyondEvil
Copy link
Contributor Author

I've asked the people that filed the issues to do some testing on Windows since I don't have access to any windows machines (tried setting something up in a VM, but I've been away from Windows too long).

But it would be great if either of you have the possibility to do some smoke-testing? @RibeiroAna @davehunt

@EricDelaney
Copy link

@BeyondEvil Your change worked for me as well as it now saves the results correctly without error-ing out. Awesome

@BeyondEvil
Copy link
Contributor Author

@BeyondEvil Your change worked for me as well as it now saves the results correctly without error-ing out. Awesome

Thanks @EricDelaney !

Awesome, as soon as I can get someone to approve the PR, I'll create a new release. 👍

@BeyondEvil
Copy link
Contributor Author

ping @davehunt 🙏

davehunt
davehunt approved these changes Aug 6, 2019
View reviewed changes
Copy link
Collaborator
@davehunt davehunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks Jim!

@BeyondEvil BeyondEvil merged commit 9dd249f into pytest-dev:master Aug 6, 2019
@BeyondEvil BeyondEvil deleted the fix-invalid-asset-filename branch August 6, 2019 11:57
@ssbarnea ssbarnea added the bug This issue/PR relates to a bug. label Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davehunt davehunt davehunt approved these changes

@RibeiroAna RibeiroAna Awaiting requested review from RibeiroAna

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add html anchors to each stdout line can not embed image on windows hosts using extra.png(image)
4 participants
@BeyondEvil @EricDelaney @davehunt @ssbarnea
0