8000 Remove ExceptionInfo.__str__, falling back to __repr__ by nicoddemus · Pull Request #5413 · pytest-dev/pytest · GitHub
[go: up one dir, main page]
Skip to content

Remove ExceptionInfo.__str__, falling back to __repr__#5413

Merged
nicoddemus merged 1 commit intopytest-dev:masterfrom
nicoddemus:exc-info-str-5412
Jun 7, 2019
Merged

Remove ExceptionInfo.__str__, falling back to __repr__#5413
nicoddemus merged 1 commit intopytest-dev:masterfrom
nicoddemus:exc-info-str-5412

Conversation

@nicoddemus
Copy link
Member
@nicoddemus nicoddemus commented Jun 6, 2019

Fix #5412

@codecov
Copy link
codecov bot commented Jun 6, 2019 •
edited
Loading

Codecov Report

Merging #5413 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5413      +/-   ##
==========================================
- Coverage   95.98%   95.98%   -0.01%     
==========================================
  Files         114      114              
  Lines       25523    25511      -12     
  Branches     2480     2479       -1     
==========================================
- Hits        24499    24487      -12     
  Misses        718      718              
  Partials      306      306
Impacted Files Coverage Δ
src/_pytest/_code/code.py 94.32% <ø> (-0.06%) ⬇️
testing/code/test_excinfo.py 96.55% <100%> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 450d264...65c2a81. Read the comment docs.

@blueyed
Copy link
Contributor
blueyed commented Jun 6, 2019

I think having the location there is useful in general, but should come via ExceptionInfo then instead - if wanted.

@nicoddemus
Copy link
Member Author
nicoddemus commented Jun 6, 2019

You mean adding this to ExceptionInfo.__repr__?

entry = self.traceback[-1]
loc = ReprFileLocation(entry.path, entry.lineno + 1, self.exconly())

asottile
asottile approved these changes Jun 6, 2019
View reviewed changes
Copy link
Member
@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blueyed
Copy link
Contributor
blueyed commented Jun 6, 2019

You mean adding this to ExceptionInfo.__repr__?

Yes - or something similar.

@nicoddemus
Copy link
Member Author
nicoddemus commented Jun 6, 2019

Adding the location gives this:

<ExceptionInfo ValueError tblen=2 location=C:\Users\bruno\pytest\testing\code\test_excinfo.py:338: ValueError: an error value>

Isn't that a too long?

@blueyed
Copy link
Contributor
blueyed commented Jun 7, 2019

Isn't that a too long?

Maybe, yes. But you have the exception type there twice.
I think it is fine for now as of this PR.

@nicoddemus nicoddemus merged commit 9f5c356 into pytest-dev:master Jun 7, 2019
@nicoddemus nicoddemus deleted the exc-info-str-5412 branch June 7, 2019 11:48
@tswast tswast mentioned this pull request Jul 1, 2019
Merged
@Ch3LL Ch3LL mentioned this pull request Jul 2, 2019
Merged
@leavest leavest mentioned this pull request Jul 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asottile asottile asottile approved these changes

62B5 +1 more reviewer

@blueyed blueyed blueyed approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

str() on the pytest.raises context variable doesn't behave same as normal exception catch

3 participants

@nicoddemus @blueyed @asottile
0